1697866 - Display HTTPS-Only exception pages and allow bypass them on Android

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[Christoph Kerschbaumer [:ckerschb}]

GeckoView uses different exception pages than Desktop Firefox. E.g. for https-only-mode we added some specific tests which seem hard to port to GeckoView at the moment (e.g. within Bug 1691888).

From what I can tell all other error page tests are kept within toolkit and are all disabled on android/geckoview.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

From what I'm seeing we don't handle error pages correctly for HTTPS only mode, and that's a problem beyond tests. We likely need to also change the error code here for GeckoView to behave correctly: https://searchfox.org/mozilla-central/rev/6e630edb09c3ab06d0103665b16c9ea7dce782c5/docshell/base/nsDocShell.cpp#3903-3907 (even if only for Android).

Since GV only gets the error code and not the error page name: https://searchfox.org/mozilla-central/rev/6e630edb09c3ab06d0103665b16c9ea7dce782c5/docshell/base/nsDocShell.cpp#3911-3913

Comment 2

[Emily Toop (:fluffyemily)]

Christoph, what is the timeline for shipping HTTPs only mode on Fenix? How urgently do we need to schedule this in?

Comment 3

[Christoph Kerschbaumer [:ckerschb}]

The current plan is

• https-only will remain an opt-in feature for Desktop Firefox and hence also for GV.
• However, we are planning to ship https-first, which upgrades the top-level load to https with a fallback to http in the near future. We are soon ready to do that in PBM in Nightly (see Bug 1709838). It seems all the tests for https-first (which are bundled within dom/security/test/https-first) are enabled for GV.

Arthur, anything I am missing?

Comment 4

[[:owlish] 🦉 PST]

Attachment: Bug 1697866 - Add HTTPS-only specific error code and pass it to GeckoView, to handle HTTPS-only specific errors correctly

Comment 5

[[:owlish] 🦉 PST]

Attachment: Bug 1697866 - Add HTTPS-only specific error code and pass it to GeckoView, to handle HTTPS-only specific errors correctly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/890d147bad1d
Add HTTPS-only specific error code and pass it to GeckoView, to handle HTTPS-only specific errors correctly r=agi,JulianWels,nika,ckerschb

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out changeset 890d147bad1d (Bug 1697866) for causing bustages in WindowGlobalParent.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=N_d6TdqqSm2a6IlOHKi5iw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&classifiedState=classified&revision=890d147bad1d62d4c73b4283d6777e95ae265eed

Log: https://treeherder.mozilla.org/logviewer?job_id=352427860&repo=autoland&lineNumber=14146

Backout: https://hg.mozilla.org/integration/autoland/rev/b019891f3804dff8688217db300629a548fcdd6b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2716327aeafe
Add HTTPS-only specific error code and pass it to GeckoView, to handle HTTPS-only specific errors correctly r=agi,JulianWels,nika,ckerschb

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2716327aeafe

Comment 10

[Christoph Kerschbaumer [:ckerschb}]

Clearing out my ni? queue with super old ni? requests which rendered unnecessary in the meantime.