Display HTTPS-Only exception pages and allow bypass them on Android
Categories
(GeckoView :: General, task, P1)
Tracking
(firefox94 fixed)
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: ckerschb, Assigned: owlish)
References
Details
(Whiteboard: [geckoview:m90][geckoview:m91][geckoview:m92][geckoview:m93][geckoview:m94])
Attachments
(1 file, 1 obsolete file)
GeckoView uses different exception pages than Desktop Firefox. E.g. for https-only-mode
we added some specific tests which seem hard to port to GeckoView at the moment (e.g. within Bug 1691888).
From what I can tell all other error page tests are kept within toolkit and are all disabled on android/geckoview.
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 1•3 years ago
|
||
From what I'm seeing we don't handle error pages correctly for HTTPS only mode, and that's a problem beyond tests. We likely need to also change the error code here for GeckoView to behave correctly: https://searchfox.org/mozilla-central/rev/6e630edb09c3ab06d0103665b16c9ea7dce782c5/docshell/base/nsDocShell.cpp#3903-3907 (even if only for Android).
Since GV only gets the error code and not the error page name: https://searchfox.org/mozilla-central/rev/6e630edb09c3ab06d0103665b16c9ea7dce782c5/docshell/base/nsDocShell.cpp#3911-3913
Comment 2•3 years ago
|
||
Christoph, what is the timeline for shipping HTTPs only mode on Fenix? How urgently do we need to schedule this in?
Updated•3 years ago
|
Reporter | ||
Comment 3•3 years ago
|
||
The current plan is
https-only
will remain anopt-in
feature for Desktop Firefox and hence also for GV.- However, we are planning to ship
https-first
, which upgrades the top-level load tohttps
with a fallback tohttp
in the near future. We are soon ready to do that inPBM
in Nightly (see Bug 1709838). It seems all the tests forhttps-first
(which are bundled withindom/security/test/https-first
) are enabled for GV.
Arthur, anything I am missing?
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 5•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Pushed by istorozhko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/890d147bad1d Add HTTPS-only specific error code and pass it to GeckoView, to handle HTTPS-only specific errors correctly r=agi,JulianWels,nika,ckerschb
Comment 7•3 years ago
|
||
Backed out changeset 890d147bad1d (Bug 1697866) for causing bustages in WindowGlobalParent.cpp CLOSED TREE
Log: https://treeherder.mozilla.org/logviewer?job_id=352427860&repo=autoland&lineNumber=14146
Backout: https://hg.mozilla.org/integration/autoland/rev/b019891f3804dff8688217db300629a548fcdd6b
Assignee | ||
Updated•3 years ago
|
Pushed by istorozhko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2716327aeafe Add HTTPS-only specific error code and pass it to GeckoView, to handle HTTPS-only specific errors correctly r=agi,JulianWels,nika,ckerschb
Comment 9•3 years ago
|
||
bugherder |
Reporter | ||
Comment 10•2 years ago
|
||
Clearing out my ni? queue with super old ni? requests which rendered unnecessary in the meantime.
Description
•