1697869 - Remove "exit" logic from target actors

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1673328 removed this logic within the thread actor, but we still have this pattern in the BrowsingContexTargetActor and a few leftovers in other targets.

This logic gets in the way for bug 1631451 as it creates many codepath leading to the destruction of the target actor, while all should do the exact same thing. But today there is subtle differences. This may lead to half destroyed target actor, where the actor is cleaned up but not destroyed in a protocol.js term.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1697869 - [devtools] Unify all destroy-alike sequences in target actors.

For now, we have:

• detach
• exit
• destroy
  all complexly interleaved.
  Some detach and exit won't lead to actor destruction, and may lead to pending actor
  still registered in pools...

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=CsN34YIsStCoPjgZjRjPDA.0&revision=204d3266749f856d77b2d85753809bb83b3a59c0

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1697869 - [devtools] Unify all destroy-alike sequences in target actors.

For now, we have:

• detach
• exit
• destroy
  all complexly interleaved.
  Some detach and exit won't lead to actor destruction, and may lead to pending actor
  still registered in pools...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c5af5dd0358
[devtools] Unify all destroy-alike sequences in target actors. r=nchevobbe

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5c5af5dd0358