1697918 - Audit JSWindowActorParent implementations and ensure they don't leak when moving a tab to another browser window

Status: RESOLVED WORKSFORME

(Core :: DOM: Navigation, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

There is a risk that WindowActor implementations keep the old window alive or add event listeners there or something similar, which create cross window references and when one window is then closed, the memory can't be released. That can lead to significantly higher GC/CC times and it would increase memory usage.

Comment 1

[Chris Peterson [:cpeterson]]

Jens, can someone on the DOM Core team work on this bug? Olli will provide more details in Tuesday's DOM Core meeting.

This is not a Fission-specific bug, but it is a regression from Fission adding WindowActors. This problem is probably affecting Release channel now.

Comment 2

[Jens Stutte [:jstutte]]

John will take a look.

Comment 3

[John Dai[:jdai]]

I checked all components[1] inherent from JSWindowActorParent, but I didn't find any suspicious component which could leak.

[1] https://docs.google.com/spreadsheets/d/16L8wmQgg2y4MglDnMy3WxFCdozEoevScFogzY7H1D40/edit?usp=sharing

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to John Dai[:jdai] from comment #3)

I checked all components[1] inherent from JSWindowActorParent, but I didn't find any suspicious component which could leak.

In that case, I'll resolve this bug as WORKSFORME.

Thanks for checking!