1697924 - Migration of app.update.auto incorrectly migrates `false` when there is no un-migrated pref

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Kirk Steuber (he/him) [:bytesized]]

I seem to have made a mistake right here. That is not a correct way of checking if a pref has a value. The null argument gets coerced to false when looking up boolean prefs like app.update.auto, causing it to default to false, and causing false to be migrated into the initial config file on a clean install.

This can be reproduced without a clean installation by setting app.update.auto.migrated to false, and then accessing app.update.auto's value.

I plan to fix this right away.

Comment 1

[Kirk Steuber (he/him) [:bytesized]]

Attachment: Bug 1697924 - Correctly detect un-set prefs when migrating app.update.auto r=nalexander!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/950b30c86355
Correctly detect un-set prefs when migrating app.update.auto r=nalexander

Comment 3

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Set release status flags based on info from the regressing bug 1691486

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/950b30c86355