Closed Bug 1697924 Opened 1 month ago Closed 1 month ago

Migration of app.update.auto incorrectly migrates `false` when there is no un-migrated pref

Categories

(Toolkit :: Application Update, defect, P1)

defect

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- fixed

People

(Reporter: bytesized, Assigned: bytesized)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

I seem to have made a mistake right here. That is not a correct way of checking if a pref has a value. The null argument gets coerced to false when looking up boolean prefs like app.update.auto, causing it to default to false, and causing false to be migrated into the initial config file on a clean install.

This can be reproduced without a clean installation by setting app.update.auto.migrated to false, and then accessing app.update.auto's value.

I plan to fix this right away.

Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/950b30c86355
Correctly detect un-set prefs when migrating app.update.auto r=nalexander
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.