Consider turning off search suggestions in tests by default
Categories
(Firefox :: Search, task, P3)
Tracking
()
People
(Reporter: standard8, Unassigned)
Details
Having search suggestions turned on in tests means that we may hit the network unnecessarily. As a result, we either need to turn them off, or define a separate search engine as default to "handle" the suggestions.
In the patch for bug 1697685, Dale has suggested turning off suggestions by default for tests. We should probably do this for both address bar and search bar suggestions.
I think that's reasonable to do - we'll turn them on only when we need them.
|
||
Comment 1•4 years ago
|
||
I think in certain cases we found non-critical privacy bugs because tests were hitting the network unexpectedly. I'm not contrary to this from a technical point of view, just thinking whether it may lower our testing coverage against unexpected remote fetches, thus privacy leaks. Though, users that don't want suggestions for privacy reasons are likely to set the same prefs you're going to, so it's probably not a show stopper problem.
|
||
Comment 2•4 years ago
|
||
The primary SAP these days is the urlbar and tests already have browser.urlbar.suggest.searches disabled by default, so the coverage we'd be potentially losing might not be that much. And just for parity, it makes sense to keep the two prefs in sync as far as tests are concerned, so I would support disabling browser.search.suggest.enabled too. Either that or we should re-evaluate disabling browser.urlbar.suggest.searches.
|
|
||
Comment 3•4 years ago
•
|
||
I was indeed looking for that disabling, and you're right. Green light from me then.
Description
•