1698024 - [Proton] Missing `Send to All Devices` and `Manage Devices` from Send to device context menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Bogdan Maris, Desktop QA]

Attachment: Image showing the issue

Affected versions

• Latest Nightly 88.0a1

Unaffected versions

• Firefox 86.0.1
• Firefox 87.0b9

Affected platforms

• Windows 7 64bit
• Windows 10 64bit
• macOS 10.15
• Ubuntu 20.04

Steps to reproduce

1. Start Firefox
2. Login to a Firefox account that has more then 1 device connected to it (I used one with 3 and 30 devices)
3. Right click any tab (except about: pages)
4. Click Send Tab to Device

Expected result

• Devices connected are displayed along with Send to All Devices... and Manage Devices....

Actual result

• Send to All Devices... and Manage Devices... options are missing from context menu.

Regression range

• First bad: 403ffdf9b6fb1d2be503cfb0feddae5faa3b85b7
• Last good: 73633f8e0e5860e4801288251decf1eaa6759b27
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cffeff2a28032c57f5d43a8293814d4cedbbc804&tochange=b422dd886e036907f35269f381f43785873c5296
• Potential regressor: Bug 1690131: create proton-specific fxa menu

Additional notes

• Screenshot showing the issue attached.

Suggested severity

• I would mark this an S2 because items in menus are missing.

Comment 1

[Emma Malysz]

Attachment: Bug 1698024, reintroduce 'Send to All Devices' and 'Manage Devices' buttons in app menu and context menu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59f02c384ab7
reintroduce 'Send to All Devices' and 'Manage Devices' buttons in app menu and context menu r=mhowell

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for bc failures on test/pageActions/browser_page_action_menu.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=59f02c384ab7082cb21cb99744d4622d336d5509&searchStr=bc&selectedTaskRun=Ksg6ng7QSxa994g8JIW_mQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=333265205&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/dfda1b86208afe71acf1b02af2ab7b4629ad6714

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b76ddd6a1554
reintroduce 'Send to All Devices' and 'Manage Devices' buttons in app menu and context menu r=mhowell

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b76ddd6a1554

Comment 6

[Bogdan Maris, Desktop QA]

Verified that this is fixed in latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04).