Closed Bug 1698058 Opened 1 year ago Closed 1 year ago

Cleanup download manager action icons

Categories

(Toolkit :: Themes, task)

Product:
Toolkit
Component:
Themes
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1698058 - Update downloads panel/window icons & icon button styling. r=Gijs,#desktop-theme-reviewers
48 bytes, text/x-phabricator-request
Details | Review

The download panel & separate places section use findFile.svg, while the panelUI library subview uses folder.svg + search-glass.svg.

Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attachment #9208691 - Attachment description: Bug 1698058 - Update downloads panel/window icons. r=Gijs,#desktop-theme-reviewers → Bug 1698058 - Update downloads panel/window icons & icon styling. r=Gijs,#desktop-theme-reviewers
Summary: De-duplicate find file icons → Cleanup download manager action icons
Attachment #9208691 - Attachment description: Bug 1698058 - Update downloads panel/window icons & icon styling. r=Gijs,#desktop-theme-reviewers → Bug 1698058 - Update downloads panel/window icons & icon button styling. r=Gijs,#desktop-theme-reviewers
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3d812f02347c
Update downloads panel/window icons & icon button styling. r=Gijs
Blocks: 1698234

Backed out for causing OS X build bustages.

Backout link:https://hg.mozilla.org/integration/autoland/rev/a1462b90a09216c47a8792215c6b60785806260b

Push with failures

Failure log

"INFO - package> WARNING: Found 30 duplicated files taking 236624 bytes (uncompressed)
[task 2021-03-13T01:02:32.967Z] 01:02:32 INFO - package> ERROR: The following duplicated files are not allowed:
[task 2021-03-13T01:02:32.967Z] 01:02:32 INFO - package> Firefox Nightly.app/Contents/Resources/chrome/toolkit/skin/classic/global/icons/find-file-in-folder.svg
[task 2021-03-13T01:02:32.967Z] 01:02:32 INFO - package> Firefox Nightly.app/Contents/Resources/chrome/toolkit/skin/classic/global/icons/search-glass.svg
[task 2021-03-13T01:02:32.967Z] 01:02:32 ERROR - package> make[5]: *** [/builds/worker/checkouts/gecko/toolkit/mozapps/installer/packager.mk:26: stage-package] Error 1
[task 2021-03-13T01:02:32.967Z] 01:02:32 INFO - package> make[5]: Leaving directory '/builds/worker/workspace/obj-build/browser/installer'
[task 2021-03-13T01:02:32.968Z] 01:02:32 ERROR - package> make[4]: *** [/builds/worker/checkouts/gecko/toolkit/mozapps/installer/packager.mk:111: make-package] Error 2
[task 2021-03-13T01:02:32.968Z] 01:02:32 ERROR - package> make[3]: *** [/builds/worker/checkouts/gecko/config/rules.mk:355: default] Error 2
[task 2021-03-13T01:02:32.968Z] 01:02:32 ERROR - package> make[2]: *** [/builds/worker/checkouts/gecko/browser/build.mk:6: package] Error 2
[task 2021-03-13T01:02:32.968Z] 01:02:32 ERROR - make[1]: *** [/builds/worker/checkouts/gecko/build/moz-automation.mk:110: automation/package] Error 2
[task 2021-03-13T01:02:32.968Z] 01:02:32 INFO - make[1]: *** Waiting for unfinished jobs....
[task 2021-03-13T01:02:38.390Z] 01:02:38 INFO - package-tests> make[3]: Entering directory '/builds/worker/workspace/obj-build/js/src/tests'"

Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f4c9c44a492e
Update downloads panel/window icons & icon button styling. r=Gijs
Flags: needinfo?(ntim.bugs)

https://hg.mozilla.org/mozilla-central/rev/f4c9c44a492e

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.