Closed Bug 1698065 Opened 9 months ago Closed 8 months ago

The Firefox Account icon is displayed in the toolbar overflow menu when the user is not signed in

Categories

(Firefox :: Toolbars and Customization, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox86 --- disabled
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: tbabos, Assigned: emmamalysz)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-toolbar])

Attachments

(1 file)

Affected Version:
Latest Nightly 88.0a1 (2021-03-12)
browser.proton.enabled
browser.proton.toolbar.enabled

Tested Platforms:
Windows 7/10, MacOs

Steps to reproduce:

  1. Launch Firefox and add some Toolbar icons using the Customize Toolbar...setting
  2. Shrink the window until the overflow >> button is displayed for the toolbar
  3. Click on the overflow menu button

Expected Result:
Only the icons the are placed on the toolbar should be displayed in the overflow menu

Actual Result:
The Firefox Account icon is displayed in the overflow menu (no signed in user)
Gif: https://drive.google.com/file/d/1e7GhzX6R84-ALEwgjvdE4c2nfwC4RZcn/view

Note:
This is specific to Proton Related changes. On Firefox Release 86 if I remove the Firefox Account icon from the toolbar (on Proton it is already removed when the user is not signed in), the icon will not be displayed in the overflow menu.

Priority: -- → P3

Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.

Priority: P3 → P1
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff26493b9197
ensure fxa button is hidden from overflow menu if not signed in r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified-fixed on the latest Nightly 89.0a1 (2021-03-25) on Windows 7/10, MacOS 10.15 and Ubuntu 16.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.