1698065 - The Firefox Account icon is displayed in the toolbar overflow menu when the user is not signed in

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Timea Cernea [:tbabos][inactive]]

Affected Version:
Latest Nightly 88.0a1 (2021-03-12)
browser.proton.enabled
browser.proton.toolbar.enabled

Tested Platforms:
Windows 7/10, MacOs

Steps to reproduce:

1. Launch Firefox and add some Toolbar icons using the Customize Toolbar...setting
2. Shrink the window until the overflow >> button is displayed for the toolbar
3. Click on the overflow menu button

Expected Result:
Only the icons the are placed on the toolbar should be displayed in the overflow menu

Actual Result:
The Firefox Account icon is displayed in the overflow menu (no signed in user)
Gif: https://drive.google.com/file/d/1e7GhzX6R84-ALEwgjvdE4c2nfwC4RZcn/view

Note:
This is specific to Proton Related changes. On Firefox Release 86 if I remove the Firefox Account icon from the toolbar (on Proton it is already removed when the user is not signed in), the icon will not be displayed in the overflow menu.

Comment 1

[Romain Testard [:RT]]

Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.

Comment 2

[Emma Malysz]

Attachment: Bug 1698065, ensure fxa button is hidden from overflow menu if not signed in

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff26493b9197
ensure fxa button is hidden from overflow menu if not signed in r=sfoster

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ff26493b9197

Comment 5

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on the latest Nightly 89.0a1 (2021-03-25) on Windows 7/10, MacOS 10.15 and Ubuntu 16.04.