Closed Bug 1698151 Opened 4 years ago Closed 4 years ago

Focus not visible on web content dialog (alert) prompt buttons when the containing window is not active/focused at the moment the dialog appears

Categories

(Firefox :: Tabbed Browser, defect, P3)

Desktop
All
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox88 --- affected

People

(Reporter: Gijs, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-modals])

Reported by Vicky via slack: the focus indicator isn't always present in content modal dialogs. She's seeing it missing on Windows when gcal switches tabs because it alerts for an event. With a quick manual test using setTimeout to invoke alert, I'm not able to reproduce quickly on current nightly, so not entirely sure what is happening, but we should probably look into it...

This seems to also affect the previous/existing implementation of page-generated dialogs, and depends on whether the window is the active window, and is independent of tabswitches - if you run:

setTimeout(() => alert('hi'), 5000)

and switch to another Windows app in the next 5s, and then alt-tab back, the issue reproduces.

Because this isn't new in Proton, and because it's a bit of an edgecase, I don't think we should focus on it for that project.

Summary: [Proton] Focus not restored to content modal dialogs for (automatic?) tab switches → Focus not set on web content dialog (alert) prompt buttons when the containing window is not active/focused at the moment the dialog appears
Summary: Focus not set on web content dialog (alert) prompt buttons when the containing window is not active/focused at the moment the dialog appears → Focus not visible on web content dialog (alert) prompt buttons when the containing window is not active/focused at the moment the dialog appears

AIUI with bug 1699682 and bug 1699259 this should now be consistent, and focus rings should not be present in the new style modal dialogs until you manually change focus with the keyboard inside the dialog, per discussions in the MR1 experience review last week.

Severity: -- → S3
Status: NEW → RESOLVED
Closed: 4 years ago
Depends on: 1699682, 1699259
Priority: -- → P3
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.