Closed Bug 1698195 Opened 3 years ago Closed 3 years ago

Fix and re-enable toolkit/components/url-classifier/tests/mochitest/test_classifier.html test for Fission opt

Categories

(Core :: Privacy: Anti-Tracking, defect, P2)

Product:
Core
Component:
Privacy: Anti-Tracking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Project Flags:
Fission Milestone Future
Tracking Flags:
Tracking Status
firefox-esr78 --- disabled
firefox-esr91 --- disabled
firefox86 --- disabled
firefox87 --- disabled
firefox88 --- disabled
firefox91 --- disabled
firefox92 --- wontfix
firefox93 --- fixed

People

(Reporter: cpeterson, Assigned: timhuang)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 1698195 - Part 1: Change the test domain to mochi.test for test_classifier.html to comply with principal vetting. r?dimi
48 bytes, text/x-phabricator-request
Details | Review
Bug 1698195 - Part 2: Enable test_classifier.html for fission. r?dimi
48 bytes, text/x-phabricator-request
Details | Review

toolkit/components/url-classifier/tests/mochitest/test_classifier.html was disabled for Fission in debug builds on Windows and macOS by bug 1694833:

https://hg.mozilla.org/integration/autoland/rev/4b99cb914aad#l2.11

[test_classifier.html]
skip-if =
    (os == 'linux' && debug) # Bug 1199778
    fission && (os == 'win' || os == 'mac') && debug  # Bug 1694833 - initial triage

This url-classifier test failure is not a Layout bug. I think "Privacy: Anti-Tracking" is the right component.

Component: Layout → Privacy: Anti-Tracking

This bug is most likely a test race since this failure only happens on debug builds (include on Linux debug without Fission).

Doesn't need to block Fission MVP since the test is at least running fine on Fission opt.

Fission Milestone: ? → Future
Summary: Fix and re-enable toolkit/components/url-classifier/tests/mochitest/test_classifier.html test for Fission → Fix and re-enable toolkit/components/url-classifier/tests/mochitest/test_classifier.html test for Fission opt
Severity: -- → S3
Priority: -- → P3
Priority: P3 → P2
Blocks: dfpi-hq
Assignee: nobody → tihuang
Status: NEW → ASSIGNED

To comply with the principal vetting, we need to add a phish entry for
moch.test domain. So, the test_classifier.html can use this entry to
test without hitting the assertion of the principal vetting.

Attachment #9236049 - Attachment description: Bug 1698195 - Part 2: Change the test domain to mochi.test for test_classifier.html to comply with principal vetting. r?dimi → Bug 1698195 - Part 1: Change the test domain to mochi.test for test_classifier.html to comply with principal vetting. r?dimi
Attachment #9236050 - Attachment description: Bug 1698195 - Part 3: Enable test_classifier.html for fission. r?dimi → Bug 1698195 - Part 2: Enable test_classifier.html for fission. r?dimi
Attachment #9236048 - Attachment is obsolete: true
Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e09c7fdabd6
Part 1: Change the test domain to mochi.test for test_classifier.html to comply with principal vetting. r=dimi
https://hg.mozilla.org/integration/autoland/rev/932b7ae4b97c
Part 2: Enable test_classifier.html for fission. r=dimi

https://hg.mozilla.org/mozilla-central/rev/0e09c7fdabd6
https://hg.mozilla.org/mozilla-central/rev/932b7ae4b97c

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Setting status-firefox92=wontfix because we don't need to uplift this Fission test fix to Beta 92.

status-firefox91: --- → disabled
status-firefox92: --- → wontfix
status-firefox-esr91: --- → disabled
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: