1698209 - Dark Mode support for -moz-default-appearance: listbox, if widget.macos.respect-system-appearance is set to true

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P1)

Description

[Markus Stange [:mstange]]

This can be seen in the dialog opened from the "Show Update History" button on about:support.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1698209 - Make CoreUI drawing adapt to the current appearance. r=#mac-reviewers

Depends on D107754

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1698209 - Use kCUIWidgetScrollViewFrame to render listboxes. r=#mac-reviewers

This makes listboxes adapt to dark mode correctly.
I have not been able to find a public API for drawing them.

Depends on D108276

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1698209 - Draw multi-line text fields with NSTextFieldCell. r=#mac-reviewers

This makes multi-line text fields adapt to Dark Mode correctly. I haven't found
a use of them in our UI, but they exist in theory.

Depends on D108278

Comment 4

[Phabricator Automation]

Comment on attachment 9208821 [details]
Bug 1698209 - Draw multi-line text fields with NSTextFieldCell. r=#mac-reviewers

Revision D108279 was moved to bug 1699232. Setting attachment 9208821 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b939eb5115b
Make CoreUI drawing adapt to the current appearance. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/df9532be8d52
Use kCUIWidgetScrollViewFrame to render listboxes. r=mac-reviewers,bradwerth

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4b939eb5115b
https://hg.mozilla.org/mozilla-central/rev/df9532be8d52