1698303 - AnimationEventDispatcher.h:54:41: error: use of undeclared identifier 'profiler_can_accept_markers'

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, defect)

Description

[Mike Hommey [:glandium]]

When building for Linux powerpc64el, mipsel, or s390x, the build fails with:

[task 2021-03-13T22:37:49.978Z] 22:37:49     INFO -  In file included from Unified_cpp_dom_animation0.cpp:2:
[task 2021-03-13T22:37:49.978Z] 22:37:49     INFO -  In file included from /builds/worker/checkouts/gecko/dom/animation/Animation.cpp:18:
[task 2021-03-13T22:37:49.978Z] 22:37:49    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/AnimationEventDispatcher.h:54:41: error: use of undeclared identifier 'profiler_can_accept_markers'
[task 2021-03-13T22:37:49.978Z] 22:37:49     INFO -      if (aMessage == eAnimationCancel && profiler_can_accept_markers()) {
[task 2021-03-13T22:37:49.978Z] 22:37:49     INFO -                                          ^
[task 2021-03-13T22:37:49.978Z] 22:37:49    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/AnimationEventDispatcher.h:86:9: error: use of undeclared identifier 'profiler_can_accept_markers'
[task 2021-03-13T22:37:49.978Z] 22:37:49     INFO -          profiler_can_accept_markers()) {
[task 2021-03-13T22:37:49.978Z] 22:37:49     INFO -          ^
[task 2021-03-13T22:37:49.978Z] 22:37:49     INFO -  2 errors generated.

https://treeherder.mozilla.org/logviewer?job_id=333147846&repo=try&lineNumber=5611

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1698303 - Wrap code using profiler_can_accept_markers with #ifdef MOZ_GECKO_PROFILER.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8bfc2068c9f
Wrap code using profiler_can_accept_markers with #ifdef MOZ_GECKO_PROFILER. r=emilio

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d8bfc2068c9f

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1698125

Comment 6

[Florian Quèze [:florian]]

I put in bug 1698493 the patch I would have liked to fix this.