1698383 - Relax max-height on print modal for larger preview size

Status: UNCONFIRMED

(Toolkit :: Printing, defect, P3)

Description

[jscher2000]

Attachment: 960x1040-modal.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Change from maximized to resizable window and reduce width of window from 1920x1040 to 960x1040. Call up the new print modal and compare with classic print preview.

Actual results:

The new preview image is 67% of the size of classic print preview for the same-sized resizable window. There are numerous complaints on SUMO about the reduced preview size.

Expected results:

The print modal should take better advantage of the available height. This can be accomplished to some extent by changing the value at

https://searchfox.org/mozilla-central/source/browser/base/content/browser.css#1529

from

--box-ideal-height: 650;

to

--box-ideal-height: 888;

Comment 1

[jscher2000]

Attachment: 960x1040-modal-mod2.png

Showing revised size brought about by the rule change (as tested in the Browser Toolbox).

Comment 2

[jscher2000]

Attachment: 960x1040-classic.png

Classic preview for reference.

Comment 3

[jscher2000]

Attachment: 960x1040-modal-mod2-1.25.png

The proposed change is less effective with global scaling of 125% (common on smaller FHD panels) with this narrow window width but might be beneficial at wider widths.

Comment 4

[jscher2000]

Since the release of Firefox 97 and renewed complaints about the preview size, I have revisited this and I think it also would be helpful to shrink the gap between the bottom of the overlay and the bottom of the viewport:

• Increase --box-ideal-height from 650 to 888
• Force --box-block-margin to a small value such as 6px rather than allowing it to vary to up to 32px (for various @media min-height)

I can't see any problems being caused by these changes, but I've only tested on Windows 10.

In userChrome.css for now:

/** Make print overlay use available height **/
.dialogBox.printDialogBox[sizeto="available"]{
  --box-ideal-height: 888 !important;
  --box-block-margin: 6px !important;
}