1698391 - OpenPGP lacks UI to refresh keys

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect, P2)

Description

[Ladislav Láska]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

TB does not support refreshing expired OpenPGP keys (or I have not found any reasonable way in OpenPGP Key Manager dialog). Even discovering my own key again (by manually typing email address/fingerprint) only displays the dialog of the key stored in TB, not the updated one. Deleting and discovering the key again works, but is cumbersome for my own private key (that I have extended on another machine through gnupg).

Expected results:

1. The UI should have a "Refresh key" option.
2. Re-discovering a key manually should allow me to import a new signatures to extend the expiration date.

Comment 1

[Kai Engert [:KaiE:]]

Agreed. Refreshing will be improved in bug 1751885.
Let's use this bug to track a refresh UI.

Comment 2

[Kai Engert [:KaiE:]]

I think this needs a high priority and is also simple to do.

I suggest two places:
(1) in the key properties dialog, add a button "refresh", which searches online for an updated copy of this particular key, (by fingerprint)

(2) in the openpgp key manager, the same action should be triggered from a menu item, for the selected single or multiple keys.

I suggest to get this done within the next few weeks.

Comment 3

[Kai Engert [:KaiE:]]

Also, if a key was refreshed and imported, we should give feedback.
Currently, if we use OpenPGP key manager, discover keys online, and enter the ID of a key that we already have, and we find an update and merge it, we don't get any UI feedback.

Comment 4

[Kai Engert [:KaiE:]]

I thought I'd briefly add strings, as an advance preparation...

But then I decided I need to check what feedback we currently give.
And I found inconsistencies.
And I decided to quickly fix them.
In the end I spent more hours on this as I wanted, but I think it's worth it, this is an important feature to have.
Patch upcoming.

Comment 5

[Kai Engert [:KaiE:]]

Attachment: Bug 1698391 - Allowing refreshing an OpenPGP key. r=mkmelin

Comment 6

[u617804]

In line 103 should not be it if (keyList && keyList.length > 1) analog to line 55 if (keyList && keyList.length == 1) ?
(Sorry I do not have permission to make inline comments in Phabricator)

Comment 7

[Kai Engert [:KaiE:]]

(In reply to Arvidt from comment #6)

In line 103 should not be it if (keyList && keyList.length > 1) analog to line 55 if (keyList && keyList.length == 1) ?
(Sorry I do not have permission to make inline comments in Phabricator)

No this code only works verifying keyservers that return either zero or exactly one match.

Comment 8

[Magnus Melin [:mkmelin]]

(adding back nf-89 whiteboard , for posterity, if one ever goes through the list)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/25de6d52888b
Allowing refreshing an OpenPGP key. r=mkmelin

Comment 10

[Kai Engert [:KaiE:]]

Comment on attachment 9274849 [details]
Bug 1698391 - Allowing refreshing an OpenPGP key. r=mkmelin

let's test functionality intended for 102 in beta

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9274849 [details]
Bug 1698391 - Allowing refreshing an OpenPGP key. r=mkmelin

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 101.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/fbc911cac8f2