popupnotification.inc.css uses variables undefined in toolkit
Categories
(Toolkit :: Themes, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox86 | --- | unaffected |
| firefox87 | --- | unaffected |
| firefox88 | --- | fixed |
| firefox89 | --- | fixed |
People
(Reporter: ntim, Assigned: dao)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [proton-door-hangers])
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
5.59 KB,
patch
|
RyanVM
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/popupnotification.inc.css#138-149
--buttons-secondary-* and --arrowpanel-dimmed-* are both only defined in browser/
(Also, this doesn't need the --arrowpanel-dimmed fallback, the default value of --buttons-secondary-* is the same as --arrowpanel-dimmed)
|
||
Comment 1•3 years ago
|
||
Set release status flags based on info from the regressing bug 1696421
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc5403c8b7ed Move --arrowpanel-dimmed* definitions to toolkit. r=mconley
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
|
|
||
Comment 5•3 years ago
|
||
The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Comment 6•3 years ago
|
||
Approval Request Comment
[Feature/Bug causing the regression]: bug 1696421
[User impact if declined]: this could be a problem for applications using toolkit, other than Firefox, such as Thunderbird
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: just moving code around
[String changes made/needed]:
|
||
Comment 7•3 years ago
|
||
Comment on attachment 9212188 [details] [diff] [review]
patch for uplift
Approved for 88.0b5.
|
|
||
Comment 8•3 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
Description
•