Closed Bug 1698405 Opened 2 years ago Closed 2 years ago

popupnotification.inc.css uses variables undefined in toolkit

Categories

(Toolkit :: Themes, defect, P3)

Product:
Toolkit
Component:
Themes
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Iteration:
89.1 - Mar 22 - Apr 4
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- fixed
firefox89 --- fixed

People

(Reporter: ntim, Assigned: dao)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-door-hangers])

Attachments

(2 files)

Bug 1698405 - Move --arrowpanel-dimmed* definitions to toolkit. r=mconley
48 bytes, text/x-phabricator-request
Details | Review
patch for uplift
5.59 KB, patch
RyanVM
: approval-mozilla-beta+
Details | Diff | Splinter Review

https://searchfox.org/mozilla-central/source/toolkit/themes/shared/popupnotification.inc.css#138-149

--buttons-secondary-* and --arrowpanel-dimmed-* are both only defined in browser/

(Also, this doesn't need the --arrowpanel-dimmed fallback, the default value of --buttons-secondary-* is the same as --arrowpanel-dimmed)

Set release status flags based on info from the regressing bug 1696421

status-firefox86: --- → unaffected
status-firefox87: --- → unaffected
status-firefox88: --- → affected
status-firefox-esr78: --- → unaffected
Priority: -- → P3
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 89.1 - Mar 22 - Apr 4
Points: --- → 1
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc5403c8b7ed
Move --arrowpanel-dimmed* definitions to toolkit. r=mconley

https://hg.mozilla.org/mozilla-central/rev/cc5403c8b7ed

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)
Attached patch patch for uplift — — Splinter Review

Approval Request Comment
[Feature/Bug causing the regression]: bug 1696421
[User impact if declined]: this could be a problem for applications using toolkit, other than Firefox, such as Thunderbird
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: just moving code around
[String changes made/needed]:

Flags: needinfo?(dao+bmo)
Attachment #9212188 - Flags: approval-mozilla-beta?

Comment on attachment 9212188 [details] [diff] [review]
patch for uplift

Approved for 88.0b5.

Attachment #9212188 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.