1698405 - popupnotification.inc.css uses variables undefined in toolkit

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P3)

Description

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/source/toolkit/themes/shared/popupnotification.inc.css#138-149

--buttons-secondary-* and --arrowpanel-dimmed-* are both only defined in browser/

(Also, this doesn't need the --arrowpanel-dimmed fallback, the default value of --buttons-secondary-* is the same as --arrowpanel-dimmed)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1696421

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1698405 - Move --arrowpanel-dimmed* definitions to toolkit. r=mconley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc5403c8b7ed
Move --arrowpanel-dimmed* definitions to toolkit. r=mconley

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cc5403c8b7ed

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch for uplift

Approval Request Comment
[Feature/Bug causing the regression]: bug 1696421
[User impact if declined]: this could be a problem for applications using toolkit, other than Firefox, such as Thunderbird
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: just moving code around
[String changes made/needed]:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9212188 [details] [diff] [review]
patch for uplift

Approved for 88.0b5.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/26592140ca65