1698438 - Update neqo to 0.4.22

Status: RESOLVED WONTFIX

(Core :: Networking: HTTP, task, P2)

Comment 2

[Dragana Damjanovic [:dragana]]

Kershaw, can you take this?

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1698438 - Neqo version 0.4.22

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Bug 1698438 - Adapt neqo_glue to v0.4.22

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/257f86638d46
Neqo version 0.4.22 r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/a27e4101f65f
Adapt neqo_glue to v0.4.22 r=necko-reviewers,dragana

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out 2 changesets (Bug 1698438) for windows build bustages.
https://hg.mozilla.org/integration/autoland/rev/138a341e26be75170167c0c05d0410adfd9d933c

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=a27e4101f65f9e9fa7f7a67dc83b87dbd595eefb&selectedTaskRun=f4oYYCK2TAiFZeu9Snmoyw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=333514708&repo=autoland&lineNumber=50161

Comment 7

[Kershaw Chang [:kershaw]]

(In reply to Cristian Brindusan [:cbrindusan] from comment #6)

Backed out 2 changesets (Bug 1698438) for windows build bustages.
https://hg.mozilla.org/integration/autoland/rev/138a341e26be75170167c0c05d0410adfd9d933c

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=a27e4101f65f9e9fa7f7a67dc83b87dbd595eefb&selectedTaskRun=f4oYYCK2TAiFZeu9Snmoyw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=333514708&repo=autoland&lineNumber=50161

Dragana, do you have an idea why the build failed only on win32 platforms?

Comment 8

[Dragana Damjanovic [:dragana]]

I found this issue: https://github.com/msys2/MINGW-packages/issues/4984

the build is mingw32 in this build.
I am not sure if we can change the order of libs inclusions.
If not we can make the feature configurable in neqo and disable it for mingw32 builds.

Comment 9

[Dragana Damjanovic [:dragana]]

https://searchfox.org/mozilla-central/source/third_party/rust/winapi/src/um/timeapi.rs

this also adds the same function, can we figure out why that one is compiling?

Comment 10

[Kershaw Chang [:kershaw]]

(In reply to Dragana Damjanovic [:dragana] from comment #9)

https://searchfox.org/mozilla-central/source/third_party/rust/winapi/src/um/timeapi.rs

this also adds the same function, can we figure out why that one is compiling?

I am also puzzled by this. Should we make the timer feature adjustable in neqo as a workaround for now?

Comment 11

[Dragana Damjanovic [:dragana]]

(In reply to Kershaw Chang [:kershaw] from comment #10)

(In reply to Dragana Damjanovic [:dragana] from comment #9)

https://searchfox.org/mozilla-central/source/third_party/rust/winapi/src/um/timeapi.rs

this also adds the same function, can we figure out why that one is compiling?

I am also puzzled by this. Should we make the timer feature adjustable in neqo as a workaround for now?

Let's do that for now and we can fix it later.

We could also try to use the winapi if neqo is build with gecko. let's chat.

Comment 12

[Kershaw Chang [:kershaw]]

We'll use neqo v0.4.23 instead.