1698441 - Remove synthesizeNativeWheelAndWaitForWheelEvent

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task)

Description

[Kartikaya Gupta (email:[e-mail])]

synthesizeNativeWheelAndWaitForWheelEvent is a callback-style function with a promise-style equivalent that should be used instead.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/jobs?repo=try&revision=3df8a0a6a9e89ae5d5ac4f5aa388fc2bd640d9bf

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2714025fead33297e4301943ecac1e5669891507

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1698441 - Remove call to synthesizeNativeWheelAndWaitForWheelEvent. r?tnikkel

This test is not actually run in CI (disabled via mochitest.ini), so
this has zero effect. Even if it did run, the call to
synthesizeNativeWheelAndWaitForWheelEvent is not passing in a callback
function; it runs the following rAF line immediately. So calling the
function that "waits for the wheel event" is pointless, we can just
call the version that synthesizes the native wheel input and it is
functionally identical.

Depends on D108441

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1698441 - Remove synthesizeNativeWheelAndWaitForWheelEvent. r?tnikkel

Depends on D108442

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fffc5a7ed9f
Remove call to synthesizeNativeWheelAndWaitForWheelEvent. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/b96dbaae4d65
Remove synthesizeNativeWheelAndWaitForWheelEvent. r=tnikkel

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5fffc5a7ed9f
https://hg.mozilla.org/mozilla-central/rev/b96dbaae4d65