1698504 - [wpt-sync] Sync PR 28077 - Revert "Make custom properties that are IACVT guaranteed-invalid"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28077 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28077
Details from upstream follow.

b'Anders Hartvoll Ruud <[e-mail]>' wrote:

Revert "Make custom properties that are IACVT guaranteed-invalid"

This reverts commit 020915b1d8c067bbe8cb9f828ff3130975428ad3, and
d928546e829a5d6a67e90d453a8d89ed7ae844eb.

Additionally, it removes the baseline for
var-reference-registered-properties-cycles.html, and re-enables the unit
test StyleCascade.RevertToCycleInKeyframe.

Change-Id: I2f3d6e0ad7df675598c0e71640deac73c8d6ad67

Reviewed-on: https://chromium-review.googlesource.com/2759698
WPT-Export-Revision: 4eb577adcfec9d4b15129c666bc8c7d0fe79910b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 28077 applied with additional changes from upstream: af6dc3928e1207f13102f58c8eda7f703e9345a9

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=67fd6ff3d4e1454ea71d2b00d70c076d8a9bbba0

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 3 subtests

Status Summary

Firefox

OK : 4
PASS : 36
FAIL : 5
ERROR: 1

Chrome

OK : 5
PASS : 43
FAIL : 16

Safari

OK : 4
PASS : 36
FAIL : 5
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/unit-cycles.html: ERROR (Chrome: OK, Safari: ERROR)
/css/css-properties-values-api/var-reference-registered-properties-cycles.html
A var() cycle between two registered properties is handled correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
A var() cycle between a registered properties and an unregistered property is handled correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
A var() cycle between a two unregistered properties is handled correctly.: FAIL (Chrome: PASS, Safari: FAIL)
A var() cycle between a syntax:'*' property and an unregistered property is handled correctly.: FAIL (Chrome: FAIL, Safari: FAIL)
Invalid at computed-value time triggers 'unset' behavior: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc159ee0cab3
[wpt PR 28077] - Revert "Make custom properties that are IACVT guaranteed-invalid", a=testonly
https://hg.mozilla.org/integration/autoland/rev/60a4f57b9716
[wpt PR 28077] - Update wpt metadata, a=testonly

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bc159ee0cab3
https://hg.mozilla.org/mozilla-central/rev/60a4f57b9716