Open Bug 1698533 Opened 4 years ago Updated 4 years ago

Remove DocShell::GetVisibility() call from nsXULPopupManager.cpp

Categories

(Core :: DOM: Navigation, task, P3)

Product:
Core
Component:
DOM: Navigation
Type:
task

Tracking

()

People

(Reporter: smacleod, Unassigned)

References

Details

Bug 1646561 removed many calls to DocShell::GetVisibility, but left https://searchfox.org/mozilla-central/rev/aa9a7136835deb0eeba00c62bb50a4a0e2cdea2d/layout/xul/nsXULPopupManager.cpp#1644 since it's still working under Fission. We should follow-up and remove this call to be consistent.

There is no such thing as Document::GetVisibility. Perhaps you meant DocShell::GetVisibility?

Severity: -- → N/A
Flags: needinfo?(smacleod)
Priority: -- → P3

(In reply to Olli Pettay [:smaug] from comment #1)

There is no such thing as Document::GetVisibility. Perhaps you meant DocShell::GetVisibility?

Woops, yup, typo. Thanks!

Flags: needinfo?(smacleod)
Summary: Remove Document::GetVisibility() call from nsXULPopupManager.cpp → Remove DocShell::GetVisibility() call from nsXULPopupManager.cpp

Do we need to fix this bug for Fission MVP? Is this a defect fix or a cleanup task?

This bug is blocked by GetInProcessParentDocshell bug 1646561, which Edgar is fixing for Fission M7a.

Fission Milestone: --- → ?

I don't quite understand https://hg.mozilla.org/mozilla-central/rev/a7513fc59f07
but this all should be parent process only. And the initial comment here talks about consistency only.

Fission Milestone: ? → ---
You need to log in before you can comment on or make changes to this bug.