Open Bug 1698558 Opened 9 months ago Updated 7 months ago

Sharing multiple tabs appears possible in Proton, causes unexpected result (shares single tab instead)

Categories

(Firefox :: Tabbed Browser, defect, P5)

Desktop
All
defect

Tracking

()

Tracking Status
firefox-esr78 --- unaffected
firefox86 --- unaffected
firefox87 --- unaffected
firefox88 --- wontfix
firefox89 --- wontfix

People

(Reporter: yoasif, Unassigned)

References

(Depends on 1 open bug, Regression)

Details

(Keywords: nightly-community, regression, Whiteboard: [proton-tabs-bar])

Steps to reproduce:

  1. Be on a Mac (have not tested Windows)
  2. Set browser.proton.enabled to true
  3. Restart Firefox
  4. Open a few tabs: Amazon, Apple, Microsoft, Google
  5. Select tabs opened in step 3
  6. Right click on Microsoft tab
  7. Select Share > Notes
  8. Click "Save" in dialog that appears
  9. Open Notes and find your saved note.

What happens:

The note saved contains a Microsoft URL.

Expected result:

The note saved should contain URLs for all selected tabs.

Since bug 1698581 is not a feature, I would expect the "Share" menu item to be disabled if I have selected multiple tabs (step 6 should not be possible above).

Has STR: --- → yes
Summary: Sharing multiple tabs picks the one that was clicked on to open the menu → Sharing multiple tabs shares only the tab that was clicked on to open the menu
Summary: Sharing multiple tabs shares only the tab that was clicked on to open the menu → Sharing multiple tabs shares only the tab that was clicked on to open the contextual menu

We don't currently have API support for sharing more than one URL, see https://searchfox.org/mozilla-central/rev/aa9a7136835deb0eeba00c62bb50a4a0e2cdea2d/widget/nsIMacSharingService.idl#22-25 and https://searchfox.org/mozilla-central/rev/aa9a7136835deb0eeba00c62bb50a4a0e2cdea2d/widget/nsIWindowsUIUtils.idl#34 .

I don't know if both Windows and macOS internally support sharing more than one link at the same time, but either way it would need a significant amount of work that isn't in scope for Proton. This is just meant as a replacement for the page action menu, which always only shared the current tab.

No longer blocks: proton-context-menus
Type: defect → enhancement
OS: Unspecified → All
Hardware: Unspecified → Desktop
Summary: Sharing multiple tabs shares only the tab that was clicked on to open the contextual menu → Sharing multiple tabs using the OS sharing functionality isn't possible

This is unexpected behavior - if the share option doesn't support sharing multiple tabs, shouldn't we disable/make insensitive to user input the share option when multiple tabs are selected?

I'm not necessarily looking for an enhancement here, but Firefox should do the right thing. As it is, this feels like a regression from pre-proton work, because the str was not possible and the bug not able to be encountered.

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Asif Youssuff from comment #2)

This is unexpected behavior - if the share option doesn't support sharing multiple tabs, shouldn't we disable/make insensitive to user input the share option when multiple tabs are selected?

It still works for the single tab, even when multiple tabs are selected, and so I don't see why disabling it would be "better".

Flags: needinfo?(gijskruitbosch+bugs)

Gijs, I think it would be better because the user would know that the behavior where their tabs are not shared is not a bug (like I encountered and filed). I can easily see a use case for the enhancement (saving a list of tabs to a document, for example), but having it not work the way I expected makes it look like Firefox is broken.

I think it is better that Firefox menus act predictably in advertising their function and expected behavior and not look broken after the user performs a function that looks like it ought to work.

(In reply to Asif Youssuff from comment #4)

Gijs, I think it would be better because the user would know that the behavior where their tabs are not shared is not a bug (like I encountered and filed). I can easily see a use case for the enhancement (saving a list of tabs to a document, for example), but having it not work the way I expected makes it look like Firefox is broken.

I think it is better that Firefox menus act predictably in advertising their function and expected behavior and not look broken after the user performs a function that looks like it ought to work.

Opening the context menu with multiple tabs selected and having "share" disappear or not be enabled is also broken, though. It's "before" the user performs a function, but equally there is no obvious way to surface an explanation as to why the menu is suddenly missing/enabled so the user would still be confused.

It also seems like enough of an edgecase that it's not worth addressing separately from actually fixing this bug.

(In reply to :Gijs (he/him) from comment #5)

I think it is better that Firefox menus act predictably in advertising their function and expected behavior and not look broken after the user performs a function that looks like it ought to work.

Opening the context menu with multiple tabs selected and having "share" disappear or not be enabled is also broken, though. It's "before" the user performs a function, but equally there is no obvious way to surface an explanation as to why the menu is suddenly missing/enabled so the user would still be confused.

I don't think it is broken, I think it is a missing feature, and the UI is correctly indicating that. It is the same reason I don't consider it broken when I see a disabled "Reopen closed tab" in a new window - the function is not available at the moment. I don't think I would try to add features to the UI to try to educate users why that or this function is not available - at most, I would add some documentation to Support Mozilla.

It also seems like enough of an edgecase that it's not worth addressing separately from actually fixing this bug.

If the enhancement is worth doing, it wouldn't be much of an edge case - and it seems like people are interested; see:

I think that the bug looks like it could be a feature, especially since this is a new feature/change in Proton, and people will be exploring application surfaces for new and changed functionality, and this is a potential papercut that they may encounter.

Has UX been consulted on this change?

Type: enhancement → defect
Summary: Sharing multiple tabs using the OS sharing functionality isn't possible → Sharing multiple tabs shares only the tab that was clicked on to open the contextual menu
See Also: → 1698581

(In reply to Asif Youssuff from comment #6)

(In reply to :Gijs (he/him) from comment #5)

I think it is better that Firefox menus act predictably in advertising their function and expected behavior and not look broken after the user performs a function that looks like it ought to work.

Opening the context menu with multiple tabs selected and having "share" disappear or not be enabled is also broken, though. It's "before" the user performs a function, but equally there is no obvious way to surface an explanation as to why the menu is suddenly missing/enabled so the user would still be confused.

I don't think it is broken, I think it is a missing feature, and the UI is correctly indicating that.

It's broken because before, you could share the current tab even if you had multiselected tabs, and if we made the change you're suggesting this would be impossible.

It also seems like enough of an edgecase that it's not worth addressing separately from actually fixing this bug.

If the enhancement is worth doing, it wouldn't be much of an edge case

This really doesn't follow the way you suggest.

  • and it seems like people are interested; see:

This is from almost 10 years before Firefox got multi-select support in the tabstrip.

This is an android question.

So, no, I don't think so.

Given the usage of the "share" UI as it existed, and the usage of multi-tab select, it's just wildly implausible that the cross-section of users is anything other than tiny in the grand scheme of things.

Has UX been consulted on this change?

UX suggested the current context menu. I haven't asked them specifically about this case, because again, the number of users affected is tiny and making additional improvements here is not in scope, and they have more important things to spend their time (of which there is not enough) on.

(In reply to :Gijs (he/him) from comment #7)

I don't think it is broken, I think it is a missing feature, and the UI is correctly indicating that.

It's broken because before, you could share the current tab even if you had multiselected tabs, and if we made the change you're suggesting this would be impossible.

That was in the page actions, though, right? It makes sense contextually that the page action would only apply to the page. It isn't like I was context clicking the tabs I had selected. I don't think this is the same thing.

This is from almost 10 years before Firefox got multi-select support in the tabstrip.

This is an android question.

So, no, I don't think so.

This is just one use case that is relevant here - is there an easy way to perform this action in Firefox today? No - selecting tabs for exporting/sharing to another application would accomplish that.

Has UX been consulted on this change?

UX suggested the current context menu. I haven't asked them specifically about this case, because again, the number of users affected is tiny and making additional improvements here is not in scope, and they have more important things to spend their time (of which there is not enough) on.

I understand not wanting to make improvements to make a release, but this is a newly created bug caused by replicating a menu option meant for a single page (from page actions) to a context that allows it to appear to apply to multiple tabs. The UX is markedly different as it is a different UI surface, and I think that UX would agree if they were consulted on the context. Is that possible?

Has Regression Range: --- → irrelevant
Keywords: regression
Regressed by: 1690569
Summary: Sharing multiple tabs shares only the tab that was clicked on to open the contextual menu → [regression] Proton: Sharing multiple tabs appears possible in Proton, causes unexpected result (shares single tab instead)
Summary: [regression] Proton: Sharing multiple tabs appears possible in Proton, causes unexpected result (shares single tab instead) → [regression] Sharing multiple tabs appears possible in Proton, causes unexpected result (shares single tab instead)

We're not going to be able to fix this for proton unless a fix for bug 1698581 is contributed by someone outside the core team.

No longer blocks: proton-context-menus
Severity: -- → S4
Has Regression Range: irrelevant → yes
Depends on: 1698581
Priority: -- → P5
See Also: 1698581
Summary: [regression] Sharing multiple tabs appears possible in Proton, causes unexpected result (shares single tab instead) → Sharing multiple tabs appears possible in Proton, causes unexpected result (shares single tab instead)
Whiteboard: [proton-tabs-bar]
You need to log in before you can comment on or make changes to this bug.