1698704 - Objective C exceptions in nsMacSharingService::GetSharingProviders: NSInvalidArgumentException: *** -[__NSPlaceholderArray initWithObjects:count:]: attempt to insert nil object from objects[0]

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Markus Stange [:mstange]]

This exception was found in the following crash reports:
https://crash-stats.mozilla.org/report/index/5d7dd5db-0f20-4246-b8a1-831c10210311
https://crash-stats.mozilla.org/report/index/1c57bb22-73b3-4376-99d2-6c9b70210313

It seems that nsMacSharingService::GetSharingProviders sometimes gets called with invalid URL strings. Then +[NSURL URLWithString:] returns nil, and then creating an NSArray for the nil URL fails, because NSArrays cannot contain nil elements.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1698704 - Return early if the created NSURL is nil. r=#mac-reviewers

This achieves the same as the previous code, but without an Objective C exception.
Before this patch, we could have called [NSArray arrayWithObject:nil], which would
have thrown an exception, which we would then have caught and turned into NS_ERROR_FAILURE.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f40d9c4e5f5
Return early if the created NSURL is nil. r=mac-reviewers,bradwerth

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2f40d9c4e5f5