1698734 - GetOrCreateListenerManager() is used to just check existence of an event listener

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

https://searchfox.org/mozilla-central/rev/526a5089c61db85d4d43eb0e46edaf1f632e853a/editor/libeditor/TextEditor.cpp#1249 seems to be creating EventListenerManager for all the objects in the event path.
GetExistingListenerManager() could be probably used here
https://searchfox.org/mozilla-central/rev/526a5089c61db85d4d43eb0e46edaf1f632e853a/dom/events/EventTarget.h#197

Comment 1

[Jonathan Kew [:jfkthame]]

Oooh, thanks for spotting that. I'm sure I had GetExistingListenerManager() in some earlier version of the patch there; I don't recall any reason we need GetOrCreate..., so let's change it.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1698734 - Don't create an EventListenerManager just to check for existing listeners. r?smaug

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1692673

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69dff8dbabec
Don't create an EventListenerManager just to check for existing listeners. r=smaug

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/69dff8dbabec