Closed Bug 1698774 Opened 3 years ago Closed 3 years ago

browser_PageActions.js should not rely on the implicit initial TestUtils.waitForCondition timer

Categories

(Firefox :: General, task)

Product:
Firefox
Component:
General
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

Bug 1698774 - browser_PageActions.js should not rely on the implicit initial TestUtils.waitForCondition timer, r=Gijs.
48 bytes, text/x-phabricator-request
Details | Review

browser_PageActions.js becomes a perma fail on some platforms (specifically Windows 7 debug) if I fix bug 1596165.

I have a patch that fixes it by adding await new Promise(requestAnimationFrame);, unfortunately I don't remember all the details as I figured this out last week and have forgotten since that.

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e5857380b1e
browser_PageActions.js should not rely on the implicit initial TestUtils.waitForCondition timer, r=Gijs.

https://hg.mozilla.org/mozilla-central/rev/2e5857380b1e

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: