1698821 - Arrows are not visible in input type "number" in the print dialog

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2021-03-16 at 11.45.28.png

When testing the print dialog in the latest Nightly, I discovered that the arrows on input fields of the type "number" are no longer visible. Please see screenshot attached.

This seems to be a regression: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=faaf9152446865a143d77e934ba2a70f21de37f5&tochange=44eddd702c0af628c34187a9f99b85b941e843eb

STR:

• open the print dialog on any page
• check the number input field, e.g. for page scaling

ER: there should be arrows

AR: there are no arrows

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1698821 - Simplify native-appearance-disabling for number spinners. r=dholbert

The root cause of this bug is that we're now accidentally using the
native theme for the spinners because GetNumberControlFrameForSpinButton
broke with my changes.

These pseudos are not exposed to content, and there's just one user of
this pseudo-class (the print.css one).

So just disable native appearance explicitly and remove that check.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1698821 - Fix GetNumberControlFrameForSpinButton. r=dholbert

It broke with bug 1698043 because we removed one wrapper.

Depends on D108653

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1698821 - Remove dead GetNumberControlFrameForTextField. r=dholbert

There's no anonymous textfield since a long time ago.

Depends on D108654

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79889167c88e
Simplify native-appearance-disabling for number spinners. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/c89f4fbacc3a
Fix GetNumberControlFrameForSpinButton. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/349d5ef73d06
Remove dead GetNumberControlFrameForTextField. r=dholbert

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/79889167c88e
https://hg.mozilla.org/mozilla-central/rev/c89f4fbacc3a
https://hg.mozilla.org/mozilla-central/rev/349d5ef73d06

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1698043