1698826 - Perma [tier2] 0:05.38 toolkit/components/glean/pytest/test_no_expired_metrics.py::test_no_metrics_expired TEST-UNEXPECTED-FAIL

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=333395188&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/EOvR1k38SxCcL6qxJeUT8w/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-03-16T14:51:46.266Z]  0:05.38 ============================= test session starts ==============================
[task 2021-03-16T14:51:46.266Z]  0:05.38 platform linux -- Python 3.6.9, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/python-test/bin/python
[task 2021-03-16T14:51:46.266Z]  0:05.38 rootdir: /builds/worker/checkouts/gecko, inifile: /builds/worker/checkouts/gecko/config/mozunit/mozunit/pytest.ini
[task 2021-03-16T14:51:46.266Z]  0:05.38 collecting ... collected 1 item
[task 2021-03-16T14:51:46.266Z]  0:05.38 
[task 2021-03-16T14:51:46.266Z]  0:05.38 toolkit/components/glean/pytest/test_no_expired_metrics.py::test_no_metrics_expired TEST-UNEXPECTED-FAIL
[task 2021-03-16T14:51:46.266Z]  0:05.38 
[task 2021-03-16T14:51:46.266Z]  0:05.38 =================================== FAILURES ===================================
[task 2021-03-16T14:51:46.266Z]  0:05.38 ___________________________ test_no_metrics_expired ____________________________
[task 2021-03-16T14:51:46.266Z]  0:05.38 
[task 2021-03-16T14:51:46.266Z]  0:05.38     def test_no_metrics_expired():
[task 2021-03-16T14:51:46.266Z]  0:05.38         """
[task 2021-03-16T14:51:46.266Z]  0:05.38         Of all the metrics included in this build, are any expired?
[task 2021-03-16T14:51:46.266Z]  0:05.38         If so, they must be removed or renewed.
[task 2021-03-16T14:51:46.266Z]  0:05.38 
[task 2021-03-16T14:51:46.267Z]  0:05.38         (This also checks other lints, as a treat.)
[task 2021-03-16T14:51:46.267Z]  0:05.38         """
[task 2021-03-16T14:51:46.267Z]  0:05.38         app_version = buildconfig.substs.get("MOZ_APP_VERSION")
[task 2021-03-16T14:51:46.267Z]  0:05.38 
[task 2021-03-16T14:51:46.267Z]  0:05.38 >       options = run_glean_parser.get_parser_options(app_version)
[task 2021-03-16T14:51:46.267Z]  0:05.38 
[task 2021-03-16T14:51:46.267Z]  0:05.38 toolkit/components/glean/pytest/test_no_expired_metrics.py:35:
[task 2021-03-16T14:51:46.267Z]  0:05.38 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[task 2021-03-16T14:51:46.267Z]  0:05.38 
[task 2021-03-16T14:51:46.267Z]  0:05.38 moz_app_version = None
[task 2021-03-16T14:51:46.267Z]  0:05.38 
[task 2021-03-16T14:51:46.267Z]  0:05.38     def get_parser_options(moz_app_version):
[task 2021-03-16T14:51:46.267Z]  0:05.38 >       app_version_major = moz_app_version.split(".", 1)[0]
[task 2021-03-16T14:51:46.267Z]  0:05.38 E       AttributeError: 'NoneType' object has no attribute 'split'
[task 2021-03-16T14:51:46.267Z]  0:05.38 
[task 2021-03-16T14:51:46.267Z]  0:05.38 toolkit/components/glean/build_scripts/glean_parser_ext/run_glean_parser.py:18: AttributeError
[task 2021-03-16T14:51:46.267Z]  0:05.38 =========================== 1 failed in 0.06 seconds ===========================
[task 2021-03-16T14:51:46.267Z]  0:05.38 Setting retcode to 1 from /builds/worker/checkouts/gecko/toolkit/components/glean/pytest/test_no_expired_metrics.py
[task 2021-03-16T14:51:46.361Z]  0:05.48 /builds/worker/checkouts/gecko/toolkit/components/glean/pytest/test_glean_parser_cpp.py```

Comment 1

[Natalia Csoregi [:nataliaCs]]

This seems to be caused by https://treeherder.mozilla.org/jobs?repo=autoland&revision=85c7bc87fa253397e853923d66df5bac69fb318b
Chris, could you take a quick look over this when possible?
Thank you.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1696916

Comment 3

[Chris H-C :chutten]

Does... does this suite run without knowing what version it's testing?

Tagging :Aryx -- this is my attempt at moving the build failure to a test failure for bug 1696890. Do you know who's responsible for this suite? Maybe those folks will be able to tell me how to get at the version information if it's not available on buildconfig.substs.get("MOZ_APP_VERSION")

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Reading the version file works. Asking the "Firefox CI" channel if there is a better solution is also an option.

Comment 5

[Chris H-C :chutten]

Attachment: Bug 1698826 - Ask for version from version.txt not buildconfig in python-test r?janerik!

Comment 6

[Intermittent Failures Robot]

16 failures in 754 pushes (0.021 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 9
• mozilla-central: 7

Platform and build breakdown:

• windows10-64: 4
  • opt: 4
• macosx1014-64: 4
  • opt: 4
• linux1804-64: 8
  • opt: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1698826&startday=2021-03-17&endday=2021-03-17&tree=all

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2b34ae896e8
Ask for version from version.txt not buildconfig in python-test r=janerik

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a2b34ae896e8

Comment 9

[Intermittent Failures Robot]

38 failures in 4257 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

This is the #23 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 25
• mozilla-central: 13

Platform and build breakdown:

• windows10-64: 10
  • opt: 10
• linux1804-64: 19
  • opt: 19
• macosx1014-64: 9
  • opt: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1698826&startday=2021-03-15&endday=2021-03-21&tree=all