1698981 - Focus rings are not visible in (at least) permission panels when Proton is enabled

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

We've got focus rings on the checkboxes and menulists, but we appear to be missing them on the buttons.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1698981 - Show focus rings for panel footer buttons, both normal and menulike. r?Itiel!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/177159d72cd3
Show focus rings for panel footer buttons, both normal and menulike. r=Itiel,desktop-theme-reviewers

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/177159d72cd3

Comment 4

[Oana Botisan, Desktop QA]

Verified the fix using Firefox 89.0b4 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.15. On Windows and Ubuntu the issue is not reproducing anymore.

However on macOS the focus remains only on "Learn more" hyperlink and it's not visible in some cases (or it's hard to see if Dark Theme is used). But I would like to mention that this issue is reproducing with Proton disabled as well.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Thanks, Oana. Can a new bug be filed for the issue you mentioned in comment 4?

Comment 6

[Oana Botisan, Desktop QA]

According to comment 4. I will mark this bug as verified fixed.
The other issues that were mentioned can be tracked using bug 1715211 and bug 1715207.