1699008 - Intermittent devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js | the markup view is still rendered fine -

Status: ASSIGNED

(DevTools :: Framework, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=333469618&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ByN54UKjTB-U95ri8XwfZQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-03-17T00:25:57.514Z] 00:25:57     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js | Toolbar is still visible - 
[task 2021-03-17T00:25:57.515Z] 00:25:57     INFO - Check that the markup view is rendered correctly and elements can be selected
[task 2021-03-17T00:25:57.515Z] 00:25:57     INFO - Buffered messages finished
[task 2021-03-17T00:25:57.523Z] 00:25:57     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js | the markup view is still rendered fine - 
[task 2021-03-17T00:25:57.524Z] 00:25:57     INFO - Stack trace:
[task 2021-03-17T00:25:57.525Z] 00:25:57     INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-03-17T00:25:57.526Z] 00:25:57     INFO - chrome://mochitests/content/browser/devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js:checkToolboxState:83
[task 2021-03-17T00:25:57.527Z] 00:25:57     INFO - chrome://mochitests/content/browser/devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js:null:70
[task 2021-03-17T00:25:57.528Z] 00:25:57     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1089
[task 2021-03-17T00:25:57.529Z] 00:25:57     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1129
[task 2021-03-17T00:25:57.530Z] 00:25:57     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:949
[task 2021-03-17T00:25:57.531Z] 00:25:57     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:1037
[task 2021-03-17T00:25:57.532Z] 00:25:57     INFO - Selecting the node for 'ul.logs'
[task 2021-03-17T00:25:57.533Z] 00:25:57     INFO - GECKO(1529) | [Parent 1529, Main Thread] WARNING: NS_ENSURE_TRUE(GetOwner() && !mCanceled) failed: file /builds/worker/checkouts/gecko/image/imgRequestProxy.cpp:909
[task 2021-03-17T00:25:57.534Z] 00:25:57     INFO - GECKO(1529) | [Parent 1529, Main Thread] WARNING: NS_ENSURE_TRUE(GetOwner() && !mCanceled) failed: file /builds/worker/checkouts/gecko/image/imgRequestProxy.cpp:909
[task 2021-03-17T00:25:57.535Z] 00:25:57     INFO - GECKO(1529) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2021-03-17T00:25:57.536Z] 00:25:57     INFO - Check that the debugger has some sources
[task 2021-03-17T00:25:57.614Z] 00:25:57     INFO - Wait for doc_backward_forward_navigation.html to be displayed in the debugger source panel
[task 2021-03-17T00:25:57.723Z] 00:25:57     INFO - GECKO(1529) | [Child 1828: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7f43e7cc0000) [pid = 1828] [serial = 41] [outer = 0] [url = about:blank]
[task 2021-03-17T00:25:58.000Z] 00:25:58     INFO - GECKO(1529) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2021-03-17T00:25:58.042Z] 00:25:58     INFO - GECKO(1529) | [Parent 1529, Main Thread] WARNING: NS_ENSURE_TRUE(weakFrame.IsAlive()) failed: file /builds/worker/checkouts/gecko/layout/xul/nsXULPopupManager.cpp:1068
[task 2021-03-17T00:25:58.090Z] 00:25:58     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js | The debugger has the expected source - 
[task 2021-03-17T00:25:58.091Z] 00:25:58     INFO - Leaving test bound 
[task 2021-03-17T00:25:58.359Z] 00:25:58     INFO - GECKO(1529) | console.error: (new Error("Connection closed, pending request to server0.conn45.child4/inspectorActor4, type supportsHighlighters failed\n\nRequest stack:\nrequest@resource://devtools/shared/protocol/Front.js:288:14\ngenerateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:46:19\nsupportsEyeDropper@resource://devtools/client/inspector/inspector.js:1232:40\nsetupToolbar@resource://devtools/client/inspector/inspector.js:1250:42\nonRootNodeAvailable@resource://devtools/client/inspector/inspector.js:1340:12\nAsync*onResourceAvailable@resource://devtools/client/inspector/inspector.js:1310:16\n_notifyWatchers@resource://devtools/shared/resources/resource-watcher.js:634:24\nlater@resource://devtools/shared/throttle.js:33:19\nnotify@resource://gre/modules/Timer.jsm:62:17\n", "resource://devtools/shared/protocol/Front.js", 99))
[task 2021-03-17T00:26:01.195Z] 00:26:01     INFO - Removing tab.
[task 2021-03-17T00:26:01.196Z] 00:26:01     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2021-03-17T00:26:01.211Z] 00:26:01     INFO - Got event: 'TabClose' on [object XULElement].
[task 2021-03-17T00:26:01.219Z] 00:26:01     INFO - GECKO(1529) | [Parent 1529, Main Thread] WARNING: NS_ENSURE_TRUE(uri) failed: file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1327
[task 2021-03-17T00:26:01.227Z] 00:26:01     INFO - GECKO(1529) | [Parent 1529, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp:181
[task 2021-03-17T00:26:01.235Z] 00:26:01     INFO - Tab removed and finished closing```

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This landed a week ago in bug 1697450. Is this bug a duplicate of bug 1697542?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Probably, yes

Comment 3

[Intermittent Failures Robot]

18 failures in 4257 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 17
• try: 1

Platform and build breakdown:

• linux1804-64: 5
  • debug: 5
• linux1804-64-asan: 12
  • opt: 12
• windows10-64: 1
  • asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-03-15&endday=2021-03-21&tree=all

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

In the last 7 days there have been 34 occurrences, most on linux1804-64-asan opt, some on linux1804-64 debug.

Recent failure: https://treeherder.mozilla.org/logviewer?job_id=334655915&repo=autoland&lineNumber=3240

Alexandre, is this concerning?

Comment 5

[Intermittent Failures Robot]

42 failures in 3967 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #33 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 34
• mozilla-beta: 4
• try: 3
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-asan: 32
  • opt: 32
• linux1804-64: 7
  • debug: 7
• windows10-64: 3
  • asan: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-03-22&endday=2021-03-28&tree=all

Comment 6

[Intermittent Failures Robot]

50 failures in 3125 pushes (0.016 failures/push) were associated with this bug in the last 7 days.

This is the #25 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 38
• mozilla-central: 6
• mozilla-beta: 6

Platform and build breakdown:

• linux1804-64: 8
  • debug: 8
• linux1804-64-asan: 41
  • opt: 41
• windows10-64: 1
  • asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-03-29&endday=2021-04-04&tree=all

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

I'm going to have a look

Comment 8

[Intermittent Failures Robot]

15 failures in 707 pushes (0.021 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 13
• try: 1
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-asan: 13
  • opt: 13
• linux1804-64: 2
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-04-08&endday=2021-04-08&tree=all

Comment 9

[Intermittent Failures Robot]

61 failures in 3854 pushes (0.016 failures/push) were associated with this bug in the last 7 days.

This is the #22 most frequent failure this week.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 51
• mozilla-central: 8
• try: 2

Platform and build breakdown:

• linux1804-64-asan: 53
  • opt: 53
• windows10-64: 2
  • asan: 2
• linux1804-64: 6
  • debug: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-04-05&endday=2021-04-11&tree=all

Comment 10

[Intermittent Failures Robot]

16 failures in 649 pushes (0.025 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 16

Platform and build breakdown:

• linux1804-64-asan: 15
  • opt: 15
• windows10-64: 1
  • asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-04-13&endday=2021-04-13&tree=all

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1699008 - Reduce browser_toolbox_backward_forward_navigation.js intermittent. r=ochameau.

This patch does a few thing to try to reduce intermittent failures on this test.

First, the test document has a script that adds dom nodes, js sources and stylesheet
to the document every 200ms. It might that the navigateTo call we were using to navigate
to the document would never resolve, as the load event won't fire because of the constant
addition of stylesheets and scripts.
This is fixed by not using navigateTo, as we don't really need the document to be ready,
but only register the navigation so later in the test we can do backward and forward navigations.

On some platform, the test takes a very long time, so we need to extend the timeout.

We're adding some guards around sources, so we don't try to handle them when the toolbox
is already destroyed.

On the inspector side, we were waiting for the inspector front to be listening for stylesheets
before initializing the walker front, which possibly introduces some delay. As the walker
does not need to rely on listening to stylesheet, we retrieve it earlier.
We also set the will-navigate event listener on the targetFront before waiting for the
inspector front to be ready, so we avoid potential race.

Finally, we added some optional chaining operator to avoid a few exceptions while the
toolbox navigates/closes.

Comment 12

[Intermittent Failures Robot]

57 failures in 4255 pushes (0.013 failures/push) were associated with this bug in the last 7 days.

This is the #33 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 46
• try: 4
• mozilla-central: 7

Platform and build breakdown:

• linux1804-64-asan: 46
  • opt: 46
• windows10-64: 2
  • asan: 2
• linux1804-64: 9
  • debug: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-04-12&endday=2021-04-18&tree=all

Comment 13

[Natalia Csoregi [:nataliaCs]]

Update:

There have been 38 failures within the last 7 days:

• 1 failure on Windows 10 x64 asan
• 25 failures on Linux 18.04 x64 asan opt
• 12 failures on Linux 18.04 x64 debug

Recent failure: https://treeherder.mozilla.org/logviewer?job_id=337515399&repo=autoland&lineNumber=4581

[task 2021-04-23T00:09:08.272Z] 00:09:08     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js | Toolbar is still visible - 
[task 2021-04-23T00:09:08.273Z] 00:09:08     INFO - Check that the markup view is rendered correctly and elements can be selected
[task 2021-04-23T00:09:08.274Z] 00:09:08     INFO - Buffered messages finished
[task 2021-04-23T00:09:08.275Z] 00:09:08     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js | the markup view is still rendered fine - 
[task 2021-04-23T00:09:08.275Z] 00:09:08     INFO - Stack trace:
[task 2021-04-23T00:09:08.276Z] 00:09:08     INFO - chrome://mochikit/content/browser-test.js:test_ok:1341
[task 2021-04-23T00:09:08.276Z] 00:09:08     INFO - chrome://mochitests/content/browser/devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js:checkToolboxState:83
[task 2021-04-23T00:09:08.277Z] 00:09:08     INFO - chrome://mochitests/content/browser/devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js:null:70
[task 2021-04-23T00:09:08.277Z] 00:09:08     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1096
[task 2021-04-23T00:09:08.278Z] 00:09:08     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1136
[task 2021-04-23T00:09:08.278Z] 00:09:08     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:953
[task 2021-04-23T00:09:08.279Z] 00:09:08     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:1037
[task 2021-04-23T00:09:08.280Z] 00:09:08     INFO - Selecting the node for 'ul.logs'
[task 2021-04-23T00:09:08.280Z] 00:09:08     INFO - GECKO(1536) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2021-04-23T00:09:08.281Z] 00:09:08     INFO - GECKO(1536) | [Parent 1536, Main Thread] WARNING: NS_ENSURE_TRUE(GetOwner() && !mCanceled) failed: file /builds/worker/checkouts/gecko/image/imgRequestProxy.cpp:909
[task 2021-04-23T00:09:08.289Z] 00:09:08     INFO - GECKO(1536) | [Parent 1536, Main Thread] WARNING: NS_ENSURE_TRUE(GetOwner() && !mCanceled) failed: file /builds/worker/checkouts/gecko/image/imgRequestProxy.cpp:909
[task 2021-04-23T00:09:08.350Z] 00:09:08     INFO - GECKO(1536) | [Parent 1536, Main Thread] WARNING: NS_ENSURE_TRUE(GetOwner() && !mCanceled) failed: file /builds/worker/checkouts/gecko/image/imgRequestProxy.cpp:909
[task 2021-04-23T00:09:08.351Z] 00:09:08     INFO - GECKO(1536) | [Parent 1536, Main Thread] WARNING: NS_ENSURE_TRUE(GetOwner() && !mCanceled) failed: file /builds/worker/checkouts/gecko/image/imgRequestProxy.cpp:909
[task 2021-04-23T00:09:08.371Z] 00:09:08     INFO - Check that the debugger has some sources
[task 2021-04-23T00:09:08.459Z] 00:09:08     INFO - Wait for doc_backward_forward_navigation.html to be displayed in the debugger source panel
[task 2021-04-23T00:09:08.540Z] 00:09:08     INFO - GECKO(1536) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
[task 2021-04-23T00:09:08.544Z] 00:09:08     INFO - GECKO(1536) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2021-04-23T00:09:08.544Z] 00:09:08     INFO - GECKO(1536) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2021-04-23T00:09:08.702Z] 00:09:08     INFO - GECKO(1536) | [Parent 1536, Main Thread] WARNING: NS_ENSURE_TRUE(weakFrame.IsAlive()) failed: file /builds/worker/checkouts/gecko/layout/xul/nsXULPopupManager.cpp:1266
[task 2021-04-23T00:09:08.722Z] 00:09:08     INFO - TEST-PASS | devtools/client/framework/test/browser_toolbox_backward_forward_navigation.js | The debugger has the expected source -

Comment 14

[Atila Butkovits]

Attachment: Bug 1699008 - disable browser_toolbox_backward_forward_navigation.js on Linux_64 for frequent failures. r=#intermittent-reviewers

Comment 15

[Intermittent Failures Robot]

35 failures in 3224 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #30 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 26
• mozilla-central: 6
• mozilla-beta: 2
• try: 1

Platform and build breakdown:

• linux1804-64-asan: 22
  • opt: 22
• windows10-64: 2
  • asan: 2
• linux1804-64: 11
  • debug: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-04-19&endday=2021-04-25&tree=all

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2165389b8c69
disable browser_toolbox_backward_forward_navigation.js on Linux_64 for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD

Comment 17

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2165389b8c69

Comment 18

[Intermittent Failures Robot]

17 failures in 3706 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 10
• try: 3
• mozilla-beta: 3
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-asan: 11
  • opt: 11
• linux1804-64: 3
  • debug: 3
• windows10-32: 1
  • debug: 1
• windows10-64: 2
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-04-26&endday=2021-05-02&tree=all

Comment 19

[Alexandre Poirot [:ochameau]]

The test has been fixed and re-enabled in bug 1707823.

Comment 20

[Intermittent Failures Robot]

3 failures in 3279 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1
• mozilla-beta: 2

Platform and build breakdown:

• linux1804-64-asan: 2
  • opt: 2
• windows10-64-devedition: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-05-03&endday=2021-05-09&tree=all

Comment 21

[Intermittent Failures Robot]

3 failures in 3061 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1
• mozilla-beta: 2

Platform and build breakdown:

• linux1804-64-asan: 2
  • opt: 2
• linux1804-64: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-05-17&endday=2021-05-23&tree=all

Comment 22

[Intermittent Failures Robot]

2 failures in 2908 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 2

Platform and build breakdown:

• linux1804-64-asan: 1
  • opt: 1
• linux1804-64: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-05-24&endday=2021-05-30&tree=all

Comment 23

[Intermittent Failures Robot]

3 failures in 3502 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 3

Platform and build breakdown:

• linux1804-64-asan: 2
  • opt: 2
• linux1804-64: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-06-07&endday=2021-06-13&tree=all

Comment 24

[Intermittent Failures Robot]

1 failures in 3115 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1

Platform and build breakdown:

• linux1804-64-asan: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699008&startday=2021-06-21&endday=2021-06-27&tree=all