1699063 - Address bar chiclet icons don't have a contrast with Proton default theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Petruta Horea [:phorea], Desktop Test Engineering (back on Sep 5th)]

Attachment: nightly clichet.png

[Note]:

• Recent Proton regression affecting Urlbar chiclet icons, in unfocused state

[Affected versions]:

• latest Nightly 88.0a1 20210316214855

[Affected platforms]:

• Win 10 64-bit
• Mac OSX 10.15

[Steps to reproduce]:
0. Enable Proton address bar preferences:
browser.proton.enabled
browser.proton.toolbar.enabled
browser.proton.urlbar.enabled

1. Open about:support in the address bar (or any other About: page)
2. Observe the address bar.
3. Open address bar and select a search shortcut - search mode opens
4. Focus something in page and observe the search-mode button and it's styling.

[Expected result]:
2. 4. Firefox icon chiclet (search mode indicator) is signaling that the open address is a Firefox address, matches figma https://www.figma.com/file/FjUe6ORvXZgJvI3rPuTV33/Desktop-UI-(Mozilla-Confidential-)?node-id=1729%3A66576 design

[Actual result]:
2. 4. Address bar chiclet icons don't have a contrast while the address bar is unfocused

[Regression range]:

• 2021-03-17T10:56:39.508000: DEBUG : Found commit message:
  Bug 1698499 - Simplify --toolbarbutton-{hover/active}-background and --toolbarseparator-color implementation. r=harry

Differential Revision: https://phabricator.services.mozilla.com/D108433

[Additional notes]:

• Nightly without Proton is not affected
• (Proton) Dark & Light themes are not affected, see the attachment
• Reproduces also when all the Proton prefs are enabled

Comment 1

[Tim Nguyen :ntim]

I think Marco said he was solving this.

Comment 2

[Marco Bonardo [:mak]]

chiclets are not yet styled, since bug 1696479 didn't land yet.
And we'll also need the patches from bug 1696469

Comment 3

[Marco Bonardo [:mak]]

I think this is now working as expected, could you please check on your side?

Comment 4

[Petruta Horea [:phorea], Desktop Test Engineering (back on Sep 5th)]

(In reply to Marco Bonardo [:mak] from comment #3)

I think this is now working as expected, could you please check on your side?

Yes, this looks good on 88 Proton Nightly across OSs, for search mode and extensions chiclets, but I do notice that about: pages are missing the Firefox chiclets (I suppose this is a different bug). Thank you!

Comment 5

[Marco Bonardo [:mak]]

(In reply to Petruta Horea [:phorea] from comment #4)

but I do notice that about: pages are missing the Firefox chiclets (I suppose this is a different bug).

I don't see that, what do you mean by missing? on about:preferences I see it correctly with Proton themes

Comment 6

[Petruta Horea [:phorea], Desktop Test Engineering (back on Sep 5th)]

Attachment: NoChiclet.png

Looked like the attachment on that particular profile, but it showed correctly after I refreshed the page.

Works fine with new profiles. Sorry about that.

Comment 7

[Marco Bonardo [:mak]]

It looks like you may have been in edit mode in this tab.
Thank you for double checking.