Closed Bug 1699083 Opened 4 years ago Closed 4 years ago

Remove blocklist_favicon.png and use blocked.svg instead

Categories

(Toolkit :: Themes, task)

Product:
Toolkit
Component:
Themes
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1699083 - Remove blocklist_favicon.png and use blocked.svg instead. r=jaws
48 bytes, text/x-phabricator-request
Details | Review

toolkit/themes/shared/icons/blocked.svg would just do the job.

Let's get rid of toolkit/themes/{osx,windows,linux}/global/icons/blocklist_favicon.png

Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f582c2ddf74 Remove blocklist_favicon.png and use blocked.svg instead. r=jaws

Backed out changeset 9f582c2ddf74 (bug 1699083) for WebRtcIceConnectTest webrender failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=ZqsASiPaSg2s8bnv4xyPEw.0&fromchange=1ba54f519e9d53fde50f394f0ef0a24f43b90c59&searchStr=gtest&tochange=6448c2ca2b2a5a9ba1248324152363d9c688410f

Backout link: https://hg.mozilla.org/integration/autoland/rev/6448c2ca2b2a5a9ba1248324152363d9c688410f

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=333539003&repo=autoland&lineNumber=34995

[task 2021-03-17T18:31:30.049Z] 18:31:30     INFO -  TEST-START | WebRtcIceConnectTest.TestConnectTrickleTwoStreamsOneComponent
[task 2021-03-17T18:31:30.051Z] 18:31:30     INFO -  Candidate for stream P1:stream0 initialized: candidate:0 1 UDP 2122252543 10.51.56.53 57421 typ host
[task 2021-03-17T18:31:30.051Z] 18:31:30     INFO -  Candidate for stream P1:stream1 initialized: candidate:0 1 UDP 2122252543 10.51.56.53 53078 typ host
[task 2021-03-17T18:31:30.052Z] 18:31:30     INFO -  Candidate for stream P2:stream0 initialized: candidate:0 1 UDP 2122252543 10.51.56.53 52294 typ host
[task 2021-03-17T18:31:30.052Z] 18:31:30     INFO -  Candidate for stream P2:stream1 initialized: candidate:0 1 UDP 2122252543 10.51.56.53 55364 typ host
[task 2021-03-17T18:31:30.087Z] 18:31:30     INFO -  Candidate for stream P1:stream0 initialized: candidate:1 1 UDP 1686052863 63.245.210.129 29783 typ srflx raddr 10.51.56.53 rport 57421
[task 2021-03-17T18:31:30.101Z] 18:31:30     INFO -  Candidate for stream P2:stream1 initialized: candidate:1 1 UDP 1686052863 63.245.210.129 21243 typ srflx raddr 10.51.56.53 rport 55364
[task 2021-03-17T18:31:30.122Z] 18:31:30     INFO -  Candidate for stream P1:stream1 initialized: candidate:1 1 UDP 1686052863 63.245.210.129 16901 typ srflx raddr 10.51.56.53 rport 53078
[task 2021-03-17T18:31:30.122Z] 18:31:30     INFO -  P1 Gathering complete
[task 2021-03-17T18:31:30.123Z] 18:31:30     INFO -  P1 ATTRIBUTES:
[task 2021-03-17T18:31:30.123Z] 18:31:30     INFO -  Stream P1:stream0
[task 2021-03-17T18:31:30.123Z] 18:31:30     INFO -  candidate:0 1 UDP 2122252543 10.51.56.53 57421 typ host
[task 2021-03-17T18:31:30.123Z] 18:31:30     INFO -  candidate:1 1 UDP 1686052863 63.245.210.129 29783 typ srflx raddr 10.51.56.53 rport 57421
[task 2021-03-17T18:31:30.123Z] 18:31:30     INFO -  ice-ufrag:P1-106-ufrag
[task 2021-03-17T18:31:30.124Z] 18:31:30     INFO -  ice-pwd:P1-106-pwd
[task 2021-03-17T18:31:30.124Z] 18:31:30     INFO -  Stream P1:stream1
[task 2021-03-17T18:31:30.124Z] 18:31:30     INFO -  candidate:0 1 UDP 2122252543 10.51.56.53 53078 typ host
[task 2021-03-17T18:31:30.124Z] 18:31:30     INFO -  candidate:1 1 UDP 1686052863 63.245.210.129 16901 typ srflx raddr 10.51.56.53 rport 53078
[task 2021-03-17T18:31:30.125Z] 18:31:30     INFO -  ice-ufrag:P1-108-ufrag
[task 2021-03-17T18:31:30.125Z] 18:31:30     INFO -  ice-pwd:P1-108-pwd
[task 2021-03-17T18:31:37.206Z] 18:31:37  WARNING -  TEST-UNEXPECTED-FAIL | WebRtcIceConnectTest.TestConnectTrickleTwoStreamsOneComponent | Value of: res
[task 2021-03-17T18:31:37.207Z] 18:31:37     INFO -    Actual: false
[task 2021-03-17T18:31:37.207Z] 18:31:37     INFO -  Expected: true @ /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/ice_unittest.cpp:1639
[task 2021-03-17T18:31:37.207Z] 18:31:37     INFO -  insert 'ice' (registry) succeeded: ice
[task 2021-03-17T18:31:37.207Z] 18:31:37     INFO -  insert 'ice.pref' (registry) succeeded: ice.pref
[task 2021-03-17T18:31:37.208Z] 18:31:37     INFO -  insert 'ice.pref.type' (registry) succeeded: ice.pref.type
[task 2021-03-17T18:31:37.208Z] 18:31:37     INFO -  insert 'ice.pref.type.srv_rflx' (UCHAR) succeeded: 0x64
[task 2021-03-17T18:31:37.208Z] 18:31:37     INFO -  insert 'ice.pref.type.peer_rflx' (UCHAR) succeeded: 0x6e
[task 2021-03-17T18:31:37.208Z] 18:31:37     INFO -  insert 'ice.pref.type.host' (UCHAR) succeeded: 0x7e
[task 2021-03-17T18:31:37.209Z] 18:31:37     INFO -  insert 'ice.pref.type.relayed' (UCHAR) succeeded: 0x05
[task 2021-03-17T18:31:37.209Z] 18:31:37     INFO -  insert 'ice.pref.type.srv_rflx_tcp' (UCHAR) succeeded: 0x63
[task 2021-03-17T18:31:37.209Z] 18:31:37     INFO -  insert 'ice.pref.type.peer_rflx_tcp' (UCHAR) succeeded: 0x6d
[task 2021-03-17T18:31:37.209Z] 18:31:37     INFO -  insert 'ice.pref.type.host_tcp' (UCHAR) succeeded: 0x7d
[task 2021-03-17T18:31:37.210Z] 18:31:37     INFO -  insert 'ice.pref.type.relayed_tcp' (UCHAR) succeeded: 0x00
[task 2021-03-17T18:31:37.210Z] 18:31:37     INFO -  insert 'stun' (registry) succeeded: stun
[task 2021-03-17T18:31:37.210Z] 18:31:37     INFO -  insert 'stun.client' (registry) succeeded: stun.client
[task 2021-03-17T18:31:37.210Z] 18:31:37     INFO -  insert 'stun.client.maximum_transmits' (UINT4) succeeded: 7
[task 2021-03-17T18:31:37.210Z] 18:31:37     INFO -  insert 'ice.trickle_grace_period' (UINT4) succeeded: 5000
[task 2021-03-17T18:31:37.211Z] 18:31:37     INFO -  insert 'ice.tcp' (registry) succeeded: ice.tcp
[task 2021-03-17T18:31:37.211Z] 18:31:37     INFO -  insert 'ice.tcp.so_sock_count' (INT4) succeeded: 3
[task 2021-03-17T18:31:37.211Z] 18:31:37     INFO -  insert 'ice.tcp.listen_backlog' (INT4) succeeded: 10
[task 2021-03-17T18:31:37.211Z] 18:31:37     INFO -  insert 'ice.tcp.disable' (char) succeeded: \001
[task 2021-03-17T18:31:37.212Z] 18:31:37     INFO -  insert 'ice.forced_interface_name' (string) succeeded:
[task 2021-03-17T18:31:37.212Z] 18:31:37     INFO -  insert 'ice.udp' (registry) succeeded: ice.udp
[task 2021-03-17T18:31:37.212Z] 18:31:37     INFO -  insert 'ice.udp.use_nr_resolver' (char) succeeded: \001
[task 2021-03-17T18:31:37.212Z] 18:31:37     INFO -  insert 'ice.tcp.use_nr_resolver' (char) succeeded: \001
[task 2021-03-17T18:31:37.213Z] 18:31:37     INFO -  STUN-CLIENT(srflx(IP4:10.51.56.53:57421/UDP|IP4:209.85.144.127:19305/UDP)): Received response; processing
[task 2021-03-17T18:31:37.213Z] 18:31:37     INFO -  STUN-CLIENT(srflx(IP4:10.51.56.53:55364/UDP|IP4:209.85.144.127:19305/UDP)): Received response; processing
[task 2021-03-17T18:31:37.213Z] 18:31:37     INFO -  STUN-CLIENT(srflx(IP4:10.51.56.53:53078/UDP|IP4:209.85.144.127:19305/UDP)): Received response; processing
[task 2021-03-17T18:31:37.213Z] 18:31:37     INFO -  ICE(P1): All candidates initialized
[task 2021-03-17T18:31:37.214Z] 18:31:37  WARNING -  TEST-UNEXPECTED-FAIL | WebRtcIceConnectTest.TestConnectTrickleTwoStreamsOneComponent | Value of: Gather()
[task 2021-03-17T18:31:37.214Z] 18:31:37     INFO -    Actual: false
[task 2021-03-17T18:31:37.214Z] 18:31:37     INFO -  Expected: true @ /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/ice_unittest.cpp:3215
[task 2021-03-17T18:31:37.214Z] 18:31:37     INFO -  P1 Shutdown
[task 2021-03-17T18:31:38.298Z] 18:31:38     INFO -  P2 Shutdown
[task 2021-03-17T18:31:39.332Z] 18:31:39  WARNING -  TEST-UNEXPECTED-FAIL | WebRtcIceConnectTest.TestConnectTrickleTwoStreamsOneComponent | test completed (time: 9283ms)
...

https://treeherder.mozilla.org/logviewer?job_id=333537981&repo=autoland&lineNumber=36609

[task 2021-03-17T18:11:26.160Z] 18:11:26     INFO -  TEST-START | WebRtcIceConnectTest.TestNetworkForcedOfflineTwice
[task 2021-03-17T18:11:26.162Z] 18:11:26     INFO -  Candidate for stream P1:stream0 initialized: candidate:0 1 UDP 2122252543 10.51.56.158 63916 typ host
[task 2021-03-17T18:11:26.162Z] 18:11:26     INFO -  Candidate for stream P2:stream0 initialized: candidate:0 1 UDP 2122252543 10.51.56.158 54085 typ host
[task 2021-03-17T18:11:26.198Z] 18:11:26     INFO -  Candidate for stream P2:stream0 initialized: candidate:1 1 UDP 1686052863 63.245.210.129 42301 typ srflx raddr 10.51.56.158 rport 54085
[task 2021-03-17T18:11:26.198Z] 18:11:26     INFO -  P2 Gathering complete
[task 2021-03-17T18:11:26.198Z] 18:11:26     INFO -  P2 ATTRIBUTES:
[task 2021-03-17T18:11:26.199Z] 18:11:26     INFO -  Stream P2:stream0
[task 2021-03-17T18:11:26.199Z] 18:11:26     INFO -  candidate:0 1 UDP 2122252543 10.51.56.158 54085 typ host
[task 2021-03-17T18:11:26.199Z] 18:11:26     INFO -  candidate:1 1 UDP 1686052863 63.245.210.129 42301 typ srflx raddr 10.51.56.158 rport 54085
[task 2021-03-17T18:11:26.199Z] 18:11:26     INFO -  ice-ufrag:P2-165-ufrag
[task 2021-03-17T18:11:26.200Z] 18:11:26     INFO -  ice-pwd:P2-165-pwd
[task 2021-03-17T18:11:33.230Z] 18:11:33  WARNING -  TEST-UNEXPECTED-FAIL | WebRtcIceConnectTest.TestNetworkForcedOfflineTwice | Value of: res
[task 2021-03-17T18:11:33.231Z] 18:11:33     INFO -    Actual: false
[task 2021-03-17T18:11:33.231Z] 18:11:33     INFO -  Expected: true @ /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/ice_unittest.cpp:1637
[task 2021-03-17T18:11:33.231Z] 18:11:33     INFO -  insert 'ice' (registry) succeeded: ice
[task 2021-03-17T18:11:33.232Z] 18:11:33     INFO -  insert 'ice.pref' (registry) succeeded: ice.pref
[task 2021-03-17T18:11:33.232Z] 18:11:33     INFO -  insert 'ice.pref.type' (registry) succeeded: ice.pref.type
[task 2021-03-17T18:11:33.232Z] 18:11:33     INFO -  insert 'ice.pref.type.srv_rflx' (UCHAR) succeeded: 0x64
[task 2021-03-17T18:11:33.232Z] 18:11:33     INFO -  insert 'ice.pref.type.peer_rflx' (UCHAR) succeeded: 0x6e
[task 2021-03-17T18:11:33.233Z] 18:11:33     INFO -  insert 'ice.pref.type.host' (UCHAR) succeeded: 0x7e
[task 2021-03-17T18:11:33.233Z] 18:11:33     INFO -  insert 'ice.pref.type.relayed' (UCHAR) succeeded: 0x05
[task 2021-03-17T18:11:33.233Z] 18:11:33     INFO -  insert 'ice.pref.type.srv_rflx_tcp' (UCHAR) succeeded: 0x63
[task 2021-03-17T18:11:33.233Z] 18:11:33     INFO -  insert 'ice.pref.type.peer_rflx_tcp' (UCHAR) succeeded: 0x6d
[task 2021-03-17T18:11:33.233Z] 18:11:33     INFO -  insert 'ice.pref.type.host_tcp' (UCHAR) succeeded: 0x7d
[task 2021-03-17T18:11:33.234Z] 18:11:33     INFO -  insert 'ice.pref.type.relayed_tcp' (UCHAR) succeeded: 0x00
[task 2021-03-17T18:11:33.234Z] 18:11:33     INFO -  insert 'stun' (registry) succeeded: stun
[task 2021-03-17T18:11:33.234Z] 18:11:33     INFO -  insert 'stun.client' (registry) succeeded: stun.client
[task 2021-03-17T18:11:33.234Z] 18:11:33     INFO -  insert 'stun.client.maximum_transmits' (UINT4) succeeded: 7
[task 2021-03-17T18:11:33.235Z] 18:11:33     INFO -  insert 'ice.trickle_grace_period' (UINT4) succeeded: 5000
[task 2021-03-17T18:11:33.235Z] 18:11:33     INFO -  insert 'ice.tcp' (registry) succeeded: ice.tcp
[task 2021-03-17T18:11:33.235Z] 18:11:33     INFO -  insert 'ice.tcp.so_sock_count' (INT4) succeeded: 3
[task 2021-03-17T18:11:33.235Z] 18:11:33     INFO -  insert 'ice.tcp.listen_backlog' (INT4) succeeded: 10
[task 2021-03-17T18:11:33.236Z] 18:11:33     INFO -  insert 'ice.tcp.disable' (char) succeeded: \001
[task 2021-03-17T18:11:33.236Z] 18:11:33     INFO -  insert 'ice.forced_interface_name' (string) succeeded:
[task 2021-03-17T18:11:33.236Z] 18:11:33     INFO -  insert 'ice.udp' (registry) succeeded: ice.udp
[task 2021-03-17T18:11:33.236Z] 18:11:33     INFO -  insert 'ice.udp.use_nr_resolver' (char) succeeded: \001
[task 2021-03-17T18:11:33.237Z] 18:11:33     INFO -  insert 'ice.tcp.use_nr_resolver' (char) succeeded: \001
[task 2021-03-17T18:11:33.237Z] 18:11:33     INFO -  STUN-CLIENT(srflx(IP4:10.51.56.158:54085/UDP|IP4:209.85.144.127:19305/UDP)): Received response; processing
[task 2021-03-17T18:11:33.237Z] 18:11:33     INFO -  ICE(P2): All candidates initialized
[task 2021-03-17T18:11:33.237Z] 18:11:33  WARNING -  TEST-UNEXPECTED-FAIL | WebRtcIceConnectTest.TestNetworkForcedOfflineTwice | Value of: Gather()
[task 2021-03-17T18:11:33.238Z] 18:11:33     INFO -    Actual: false
[task 2021-03-17T18:11:33.238Z] 18:11:33     INFO -  Expected: true @ /builds/worker/checkouts/gecko/dom/media/webrtc/transport/test/ice_unittest.cpp:1672
[task 2021-03-17T18:11:33.238Z] 18:11:33     INFO -  P1 Shutdown
[task 2021-03-17T18:11:34.360Z] 18:11:34     INFO -  P2 Shutdown
[task 2021-03-17T18:11:35.362Z] 18:11:35  WARNING -  TEST-UNEXPECTED-FAIL | WebRtcIceConnectTest.TestNetworkForcedOfflineTwice | test completed (time: 9203ms)
...
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/294ee16f9e45 Remove blocklist_favicon.png and use blocked.svg instead. r=jaws
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/affb6321ef4b Remove blocklist_favicon.png and use blocked.svg instead. r=jaws
Regressions: 1699260
Regressions: 1699262
Flags: needinfo?(ntim.bugs)
No longer regressions: 1699262
No longer regressions: 1699260

https://hg.mozilla.org/mozilla-central/rev/affb6321ef4b

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: