Closed Bug 1699146 Opened 3 years ago Closed 3 years ago

Fix typo in error message created by Front base class

Categories

(DevTools :: General, task, P5)

task

Tracking

(firefox88 fixed)

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: jdescottes, Assigned: henryvincent33)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

At https://searchfox.org/mozilla-central/rev/1a47a74bd5ba89f2474aa27c40bd478e853f3276/devtools/shared/protocol/Front.js#133

    if (front.parentFront && front.parentFront !== this) {
      throw new Error(
        `${this.actorID} (${this.typeName}) can't manage ${front.actorID}
        (${front.typeName}) since it has a different parentFront ${
          front.parentFront
            ? front.parentFront.actordID +
              "(" +
              front.parentFront.typeName +
              ")"
            : "<no parentFront>"
        }`
      );
    }

Here front.parentFront.actordID should be front.parentFront.actorID (actor"d"ID -> actorID).

Minor issue as it only leads to generate incorrect error messages.

Setting as good first bug

Assignee: nobody → henryvincent33
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09906b748cbc
Fix typo in error message created by Front base class r=ochameau First bug fix. Fixed typo, and then the linter wanted the code slightly reformatted.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Henry, thanks for fixing this so quickly!

(In reply to Julian Descottes [:jdescottes] from comment #4)

Henry, thanks for fixing this so quickly!

No problem! Thanks for giving me something to do on a slow evening!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: