Closed
Bug 1699158
Opened 4 years ago
Closed 4 years ago
Rename variables related to secondary buttons
Categories
(Firefox :: Theme, task, P3)
Firefox
Theme
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: bugzilla, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-foundations])
Attachments
(1 file)
This is a follow-up on this review comment.
The Proton spec talks about "secondary buttons" and Secondary colours, but that's not a well-known concept outside Proton. We should rename the variables related to secondary buttons/colors with more generic names. Dao suggests just "buttons".
|
Assignee | |
Updated•4 years ago
|
Severity: -- → N/A
|
|
Assignee | |
Updated•4 years ago
|
Points: --- → 1
|
||
Updated•4 years ago
|
Whiteboard: [proton-foundations]
|
|
||
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-689
|
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 89.1 - Mar 22 - Apr 4
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a378cf3a796
Rename variables related to non-default/non-primary buttons. r=harry
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•