Closed Bug 1699158 Opened 2 years ago Closed 2 years ago

Rename variables related to secondary buttons

Categories

(Firefox :: Theme, task, P3)

Product:
Firefox
Component:
Theme
Type:
task
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Iteration:
89.1 - Mar 22 - Apr 4
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: bugzilla, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-foundations])

Attachments

(1 file)

Bug 1699158 - Rename variables related to non-default/non-primary buttons. r=harry
48 bytes, text/x-phabricator-request
Details | Review

This is a follow-up on this review comment.

The Proton spec talks about "secondary buttons" and Secondary colours, but that's not a well-known concept outside Proton. We should rename the variables related to secondary buttons/colors with more generic names. Dao suggests just "buttons".

Severity: -- → N/A
Points: --- → 1
Whiteboard: [proton-foundations]
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 89.1 - Mar 22 - Apr 4
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a378cf3a796
Rename variables related to non-default/non-primary buttons. r=harry

https://hg.mozilla.org/mozilla-central/rev/1a378cf3a796

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1700644
You need to log in before you can comment on or make changes to this bug.