1699209 - Ensure we release shmems if we exit early in WebRenderBridgeParent messages

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

In WebRenderBridgeParent::RecvSetDisplayList and WebRenderBridgeParent::RecvEmptyTransaction we don't release our shmems if we are destroyed before the message comes in. I'm not sure if this happens in practice, but the affected path is destroying related actors for textures/etc.

https://searchfox.org/mozilla-central/rev/1a47a74bd5ba89f2474aa27c40bd478e853f3276/gfx/layers/wr/WebRenderBridgeParent.cpp#1202
https://searchfox.org/mozilla-central/rev/1a47a74bd5ba89f2474aa27c40bd478e853f3276/gfx/layers/wr/WebRenderBridgeParent.cpp#1339

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1699209 - Ensure we release shmems from messages even if WebRenderBridgeParent is destroyed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdc2de3463eb
Ensure we release shmems from messages even if WebRenderBridgeParent is destroyed. r=jrmuizel

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fdc2de3463eb