Closed Bug 1699245 Opened 4 years ago Closed 4 years ago

Right align modal buttons

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Product:
Toolkit Graveyard
Component:
Notifications and Alerts
Platform:
Desktop
Windows
Type:
defect

Tracking

(firefox89 verified)

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- verified

People

(Reporter: RT, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-modals])

Attachments

(1 file)

Bug 1699245 - Make sure dialog buttons pack to the end when Proton is enabled. r?mtigley
48 bytes, text/x-phabricator-request
Details | Review

Per experience review we should align modal buttons to the right for javascript and Firefox modals to match the Figma spec.

Blocks: proton-modals
Priority: -- → P1

Note that this probably means that the buttons should be aligned to the left, for RTL.

Severity: -- → S2
OS: Unspecified → All
Hardware: Unspecified → Desktop
Version: unspecified → Trunk
Whiteboard: [proton-modals]
Assignee: nobody → mconley

It looks like on macOS and Linux, these buttons are already right aligned. On Windows, they're not.

OS: All → Windows
Blocks: 1701365
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce9069665bc9 Make sure dialog buttons pack to the end when Proton is enabled. r=mtigley

https://hg.mozilla.org/mozilla-central/rev/ce9069665bc9

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified in latest nightly build 90.0a1 (2021-05-13) (64-bit) and beta build 89.0b11 (64-bit) for EN builds. https://bugzilla.mozilla.org/show_bug.cgi?id=1705182 for RTL this is not fixed yet.
Updating status accordingly.
Best regards,
Clara

Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: