1699352 - Fix DrawTargetD2D1::mVRAMUsageSS handling

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

This bug is created from bug 1697476 comment 10

It is weird that mVRAMUsageSS is incremented only at one place and the value is not decremented.

Comment 1

[Sotaro Ikeda [:sotaro]]

DrawTargetD2D::mVRAMUsageSS that existed in the past(Bug 738189) was added/removed correctly.

DrawTargetD2D1::mVRAMUsageSS was added by Bug 883004. And the change did not have decrement of DrawTargetD2D1::mVRAMUsageSS.

Comment 2

[Sotaro Ikeda [:sotaro]]

It seems simpler to handle the decrement like SourceSurfaceD2DTarget::mOwnsCopy that existed in the past.
https://searchfox.org/mozilla-esr45/rev/e58e94fb0696e9d99b8685348f02278a4bafced7/gfx/2d/SourceSurfaceD2DTarget.cpp#31
https://searchfox.org/mozilla-esr45/rev/e58e94fb0696e9d99b8685348f02278a4bafced7/gfx/2d/SourceSurfaceD2DTarget.cpp#133

Comment 3

[Sotaro Ikeda [:sotaro]]

During looking intoDrawTargetD2D1::mVRAMUsageSS. I found that DrawTargetD2D1::mVRAMUsageDT is not counted at all.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)

During looking intoDrawTargetD2D1::mVRAMUsageSS. I found that DrawTargetD2D1::mVRAMUsageDT is not counted at all.

Created Bug 1699361 for DrawTargetD2D1::mVRAMUsageDT.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1699352 - Fix DrawTargetD2D1::mVRAMUsageSS handling

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc678cfbe237
Fix DrawTargetD2D1::mVRAMUsageSS handling r=jrmuizel

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bc678cfbe237