1699367 - Intermittent browser/components/extensions/test/browser/browser_ext_popup_select_in_oopif.js | Select popup has the correct x origin - Got 935, expected 1205

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=333594657&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PFK5ythhSTaxK0n_AwX2tg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-03-18T06:27:22.156Z] 06:27:22     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_popup_select_in_oopif.js | Expect widget not to be overflowed - true == true - 
[task 2021-03-18T06:27:22.156Z] 06:27:22     INFO - Buffered messages finished
[task 2021-03-18T06:27:22.156Z] 06:27:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_popup_select_in_oopif.js | Select popup has the correct x origin - Got 935, expected 1205
[task 2021-03-18T06:27:22.156Z] 06:27:22     INFO - Stack trace:
[task 2021-03-18T06:27:22.156Z] 06:27:22     INFO - chrome://mochikit/content/browser-test.js:test_is:1359
[task 2021-03-18T06:27:22.156Z] 06:27:22     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_popup_select_in_oopif.js:testPopupSelectPopup:98
[task 2021-03-18T06:27:22.156Z] 06:27:22     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_popup_select_in_oopif.js | Select popup has the correct y origin - ```

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Okay, there are two kinds of failures, one is failing without Fission, the other one is failing with Fission.

Without Fission case, it's same as what I described about failures on TSAN in bug 1696718 comment 17, the popup position is simply wrong. I'd assume it's a pre-existing issue because the fix for bug 1696718 affects only for Fission and there was no automated test to test the popup position so that this new test just has started catching the pre-existing issue.

With Fission case, I think this is also somewhat related to the failures on TSAN what I described in bug 1696718 comment 17, with Fission SpecialPowers.spawn failed with an exception that the iframe's browsing context is null at that moment, which means, if the iframe's browsing context is null, we fail to propagate the extension's window position change into descendant OOP's BrowerParent because we descend down the browsing context tree when we propagate it.

Anyway, I am going to skip the test without Fission for now since the test is mainly for Fission and it looks like the Fission case failure doesn't often happen.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1699367 - Skip browser_ext_popup_select_in_oopif.js without Fission. r?kmag

The test basically was written for Fission, but unfortunately it fails
intermittently without Fission becasue, I assume, there was a pre-existing race
condition causing the failure without Fission, so we are going to skip the
test without Fission for now.

Comment 3

[Intermittent Failures Robot]

10 failures in 4257 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8
• mozilla-central: 2

Platform and build breakdown:

• windows10-64: 1
  • debug: 1
• linux1804-64: 7
  • debug: 7
• linux1804-64-shippable: 1
  • opt: 1
• linux1804-64-asan: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699367&startday=2021-03-15&endday=2021-03-21&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da6d6bf1c78d
Skip browser_ext_popup_select_in_oopif.js without Fission. r=kmag

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/da6d6bf1c78d

Comment 6

[Intermittent Failures Robot]

8 failures in 3967 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64: 5
  • debug: 5
• linux1804-64-shippable: 2
  • opt: 2
• linux1804-64-asan: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699367&startday=2021-03-22&endday=2021-03-28&tree=all