1699434 - Do not filter AAC based on sample rate, instead let decoder creation fail if we have a rate we can't handle

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

We currently filter AAC based on sample rate and will not try and create decoders if we do not receive a sample rate we expect to be supported[0]. However, following investigation in bug 1698639 it seems newer versions of Windows may support a wider range of sample rates.

We should remove the check and see if we can create a decoder instead. This will allow some users to play media with higher sample rates.

This will change the error that users see if they cannot play a file, but not in a meaningful way (IMO). The error will change from

NS_ERROR_DOM_MEDIA_FATAL_ERR (0x806e0005) - Error no decoder found for audio/mp4a-latm 

to

NS_ERROR_DOM_MEDIA_FATAL_ERR (0x806e0005) - Error creating decoder for audio/mp4a-latm

So users will not receive a harder to explain message.

It would be nice to improve on the error message so that it references the sample rate, bug 1698633 tracks having a better error message for this case.

[0] https://searchfox.org/mozilla-central/rev/f07a609a76136ef779c65185165ff5ac513cc172/dom/media/platforms/wmf/WMFDecoderModule.cpp#329-330

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1699434 - Add aac audio test files for different sample rates. r?alwu

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1699434 - Remove code that blocks WMF AAC decoding based on sample rate. r?alwu

This will allow higher sample rate decoding when the platform supports it, and
will offer a similar error in cases where the platform does not.

Depends on D109380

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37f5052c1846
Add aac audio test files for different sample rates. r=alwu
https://hg.mozilla.org/integration/autoland/rev/0913382ff7cb
Remove code that blocks WMF AAC decoding based on sample rate. r=alwu

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/37f5052c1846
https://hg.mozilla.org/mozilla-central/rev/0913382ff7cb