Closed Bug 1699492 Opened 3 years ago Closed 3 years ago

signature generation mutates stack frames

Categories

(Socorro :: Processor, defect, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

Attachments

(1 file)

When signature generation runs, the CSignatureTool does a bunch of work to normalize frames. It then persists this data in the "normalized" field thus mutating the input as a side-effect. It does this to reduce the work it needs to do if the processor ever reprocesses the crash report. However, when we reprocess, we would prefer to have any changes in signature generation affect the new signature--we don't want to cache intermediary things between runs.

Signature generation shouldn't mutate the input as a side-effect.

Grabbing this to look at today.

Assignee: nobody → willkg
Status: NEW → ASSIGNED

This was deployed to prod in bug #1706647. Marking as FIXED.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: