Closed Bug 1699523 Opened 4 years ago Closed 4 years ago

Key TRR skip reason probes by provider and split fallback probe into success and failure

Categories

(Core :: Networking: DNS, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: nhnt11, Assigned: nhnt11)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

Currently we record TRR_SKIP_REASON_DNS_WORKED, which shows us the count of native lookups that succeeded after TRR was skipped, grouped by skip reason. We can currently infer the count of native lookups that failed by subtracting this from TRR_SKIP_REASON_TRR_FIRST, but it'd be nice to record it directly e.g. put DNS_WORKED together with this new measurement in one keyed histogram TRR_SKIP_REASON_NATIVE_FALLBACK or something.

Do you want to work on this?

Severity: -- → S3
Flags: needinfo?(nhnt11)
Priority: -- → P3
Whiteboard: [necko-triaged]
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED

Keeping the needinfo because I need to request data review

Attached file Data Review Request
Flags: needinfo?(nhnt11)
Attachment #9214239 - Flags: data-review?(chutten)
Attachment #9210884 - Attachment description: Bug 1699523 - Record for each TRR skip reason the count of native fallback failures. r=#necko! → Bug 1699523 - Key TRR skip reason histograms by provider, split fallback into success and failure. r=#necko!
Summary: Record for each TRR skip reason the count of native fallback failures → Key TRR skip reason probes by provider and split fallback probe into success and failure

Comment on attachment 9214239 [details]
Data Review Request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Nihanth is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.


Result: datareview+

Attachment #9214239 - Flags: data-review?(chutten) → data-review+
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f5b433ddba98 Key TRR skip reason histograms by provider, split fallback into success and failure. r=necko-reviewers,valentin
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: