1699578 - Tweak margins and sizing of various bits in the Windows 10 context menus

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P1)

Description

[:Gijs (he/him)]

There are some positioning issues still with checkmarks and submenu arrows, as well as with the height of menuitems (they differ between iconified/checkbox items vs. non-checkbox items) that we should fix.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1699578 - adjust positioning of Windows 10 submenu arrow and checkmark as well as item height, r?jaws

This commit:

• reduces the extra height on checkbox/radio items and iconified items.
  This was caused by -moz-appearance for the icon items, and by the
  fixed height of menu-iconic-left for the checkbox/radio items.
• moves the submenu arrow left so the bounding box of the icon aligns
  with the separator ends
• moves the checkmark right based on the spec (12/8 spacing instead of
  10/10).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33a61c088863
adjust positioning of Windows 10 submenu arrow and checkmark as well as item height, r=jaws

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/33a61c088863