1699635 - Cleanup some code around EventStateManager::mAccessKeys

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, task, P2)

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1699635 - Part 1: Rename EventStateManager::GetFocusedContent to GetFocusedElement;

And make it return Element*

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1699635 - Part 2: Use Element for EventStateManager::mAccessKeys;

As we always add Element into the array

Depends on D109040

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1699635 - Part 3: Cleanup IsAccessKeyTarget in EventStateManager.cpp;

1. Use Element as argument as we always pass Element.
2. Get frame from the Element argument.

Depends on D109041

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/318c315de735
Part 1: Rename EventStateManager::GetFocusedContent to GetFocusedElement; r=masayuki
https://hg.mozilla.org/integration/autoland/rev/3d74adb00bb0
Part 2: Use Element for EventStateManager::mAccessKeys; r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ab6c6a5893c8
Part 3: Cleanup IsAccessKeyTarget in EventStateManager.cpp; r=masayuki

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/318c315de735
https://hg.mozilla.org/mozilla-central/rev/3d74adb00bb0
https://hg.mozilla.org/mozilla-central/rev/ab6c6a5893c8