Closed Bug 1699637 Opened 5 years ago Closed 2 months ago

Windows sandbox log stacktraces don't have useful symbols

Categories

(Core :: Security: Process Sandboxing, defect, P2)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: glandium, Assigned: bobowen)

References

Details

STR:

  • set security.sandbox.logging.enabled to true
  • set security.sandbox.windows.log.stackTraceDepth to some value > 0
  • open the browser console

Expected result:

  • sandbox logs with useful stack traces

Actual result:

  • sandbox logs with not very useful stack traces (they need to be copy/pasted to fix-stacks)
  • with bug 1699328, it's even worse, because enabling stack traces in the logs leads to a stack overflow crash because of infinite recursion.

The problem is that the pdb files are not used to get useful traces. With bug 1699328, the failure of SymInitialize doesn't prevent reaching the code that reads pdbs anymore, but then the sandbox blocks that access, which triggers logging, which triggers a new stack walk, that tries to read pdbs, that the sandbox blocks, etc.

Assignee: nobody → bobowencode
Severity: -- → S4
Priority: -- → P2

In bug 2050061 logging was simplified and made MOZ_LOG only.
Profiler markers were also added that mean stacks can now be obtained via the profiler in all sandboxed process types.

Status: NEW → RESOLVED
Closed: 2 months ago
Depends on: 2050061
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.