Closed Bug 1699689 Opened 4 years ago Closed 4 years ago

WebAssembly is disabled on MIPS64 simulator because isLockfree8() returns false

Categories

(Core :: JavaScript: WebAssembly, defect, P3)

Other
Unspecified
defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: lth, Assigned: lth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The reason isLockfree8() returns false is that the simulator uses the feeling-lucky atomics implementation (this is reasonable) but does not define HAS_64BIT_ATOMICS and HAS_64BIT_LOCKFREE in that library (this is not). Hence we have no wasm testing at all on the mips64 simulator.

We're running the emulator on x64 so it's fine to say we have 64-bit atomics,
and this will enable wasm on this platform.

Depends on D109069

Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89a4d7d92f4f Enable wasm for mips64 simulator. r=nbp DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: