1699691 - More TRR confirmation tests

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P2)

Description

[Valentin Gosu [:valentin]]

connectivity change, network change, uri change, steering happens, ....

Comment 1

[Valentin Gosu [:valentin]]

Attachment: Bug 1699691 - Add more confirmation tests r=#necko

Also makes sure not to trigger two confirmations when the URI pref changes.

Depends on D109601

Comment 2

[Valentin Gosu [:valentin]]

Attachment: Bug 1699691 - Only trigger CaptivePortalConnectivity confirmation event when CP was locked r=dragana!

We only need to react to a completed captive portal check when the captive
portal was previously locked. When not in a captive portal, this notification
only means the check has completed - no network properties have changed.

Depends on D109620

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/768e56ccd244
Add more confirmation tests r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/5f3eb0797c06
Only trigger CaptivePortalConnectivity confirmation event when CP was locked r=dragana,necko-reviewers

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing windows xpcshell failures on test_trr_cancel.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&fromchange=5f3eb0797c06ff38383e8fca88cbb6ed4038d02d&searchStr=xpc&tochange=dae7fefaf8278e53d864391a50ae947d5ce5747a&selectedTaskRun=QimLb7z6Rb62U1gM8yM-gQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=335595411&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/dae7fefaf8278e53d864391a50ae947d5ce5747a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aec53c369675
Add more confirmation tests r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/8f7e11867d56
Only trigger CaptivePortalConnectivity confirmation event when CP was locked r=dragana,necko-reviewers

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/aec53c369675
https://hg.mozilla.org/mozilla-central/rev/8f7e11867d56