1699701 - Convert all usages of ExperimentFeature to singleton API

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, enhancement, P1)

Description

[Kate Hudson :k88hudson]

Please also update docs

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1699701 - Convert all usages of ExperimentFeature to singleton API

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d402c8657d3f
Convert all usages of ExperimentFeature to singleton API r=k88hudson

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing newtab's activity-stream:AboutPreferences Feed and more:

https://hg.mozilla.org/integration/autoland/rev/f30c72b7e3e707c2012498f2632574b088bca6b3

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=retry%2Cusercancel%2Ctestfailed%2Cbusted%2Cexception&revision=d402c8657d3f47196a3bf5d8c253c49bf6036272
Failure log: https://treeherder.mozilla.org/logviewer?job_id=335974865&repo=autoland

[task 2021-04-09T13:19:18.529Z] TEST START | karma
[task 2021-04-09T13:20:13.307Z] webpack was not included as a framework in karma configuration, setting this automatically...
[task 2021-04-09T13:20:13.308Z] npm ERR! code ELIFECYCLE
[task 2021-04-09T13:20:13.308Z] npm ERR! errno 1
[task 2021-04-09T13:20:13.308Z] npm ERR! activity-streams@1.14.3 testmc:unit: karma start karma.mc.config.js
[task 2021-04-09T13:20:13.308Z] npm ERR! Exit status 1
[task 2021-04-09T13:20:13.308Z] npm ERR!
[task 2021-04-09T13:20:13.308Z] npm ERR! Failed at the activity-streams@1.14.3 testmc:unit script.
[task 2021-04-09T13:20:13.308Z] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[task 2021-04-09T13:20:13.308Z]
[task 2021-04-09T13:20:13.308Z] npm ERR! A complete log of this run can be found in:
[task 2021-04-09T13:20:13.308Z] npm ERR! /builds/worker/.npm/_logs/2021-04-09T13_20_13_302Z-debug.log
[task 2021-04-09T13:20:13.328Z] TEST-UNEXPECTED-FAIL karma | activity-stream:AboutPreferences Feed:#observe should try to render on event: NimbusFeatures is not defined

followed by more failures.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79fcb9d7f033
Convert all usages of ExperimentFeature to singleton API r=k88hudson

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/79fcb9d7f033