1699707 - Remove DeviceProximityEvent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

It's not in the spec anymore, and it has been disabled everywhere for years. https://searchfox.org/mozilla-central/rev/31b583bbcc9cfaacd93e785c05dda0e87d7cca4e/modules/libpref/init/StaticPrefList.yaml#1430

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1699707 - Remove DeviceProximityEvent and UserProximityEvent r=agi,annevk,smaug

Note that this removes window.ondeviceproximity and window.onuserproximity which unexpectedly have been exposed unconditionally.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e17c6f92b2bf
Remove DeviceProximityEvent and UserProximityEvent r=agi,annevk,smaug

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e17c6f92b2bf

Comment 4

[[:fabrice] Fabrice Desré]

Hi all,

This is a problematic removal for KaiOS. Can we back this out and only remove the Android specific parts as a compromise?

Thanks!

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Hi Fabrice,

I see it's disabled in the gecko-b2g fork, where does KaiOS enable it? (Sorry, the GitHub search is not very good. 😬)

Comment 6

[[:fabrice] Fabrice Desré]

Hi Kagami, we enable it on a per-device model basis, in a preference file that is not in gecko but in the device customization.

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Thanks for the quick reply. Is there a good way to see which flags are provided in KaiOS as an option but disabled by default in Gecko? We want to also remove DeviceLightEvent, so it would be helpful to know that.

Comment 8

[[:fabrice] Fabrice Desré]

(In reply to Kagami :saschanaz from comment #7)

Thanks for the quick reply. Is there a good way to see which flags are provided in KaiOS as an option but disabled by default in Gecko? We want to also remove DeviceLightEvent, so it would be helpful to know that.

Not really I'm afraid. Feel free to needinfo me if you have doubts and/or to ping me in matrix (my handle is 'fabrice').

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Hmm, could you do a quick check if KaiOS is using DeviceLightEvent (device.sensors.ambientLight.enabled)? Also, is KaiOS using both DeviceProximityEvent/UserProximityEvent or is it only using one of them?

Comment 10

[[:fabrice] Fabrice Desré]

We use the DeviceLightEvent and the UserProximityEvent ones, but not DeviceProximityEvent from what I see.

Comment 11

[Kagami Rosylight [:saschanaz] (they/them)]

Cool, I'll restore only UserProximityEvent then.

Comment 12

[Kagami Rosylight [:saschanaz] (they/them)]

Hi Fabrice again,

Could you check whether ondevicelight and onuserproximity are used or KaiOS only uses them in addEventListener form? Thanks!

(What's the best way to search in the codebase without cloning it? Does KaiOS also have a searchfox instance?)

Comment 13

[[:fabrice] Fabrice Desré]

Both onXXX and addEventListener() forms are used.

There is a searchfox instance for the gecko fork used by KaiOS at https://searchfox.org/kaios/source/ but unfortunately it would not help you much here since the UI where these events are used is in a private repository.

Comment 14

[Hamish Willee]

Hi @Kagami,

I'm documenting this change for FF89 in MDN content bug 4308. My understanding is that

• DeviceProximityEvent is removed, along with ondeviceproximity.
• UserProximityEvent, onuserproximity are still present behind device.sensors.proximity.enabled (which is false by default on desktop).
  • Is the behaviour same for desktop and android (or was this only renabled for android?). If it is restored to android how are users supposed to set the preference, when there is no preference UI on current Android Firefox?

Thanks!

Comment 15

[Kagami Rosylight [:saschanaz] (they/them)]

Hi Hamish,

You are correct, so I'm just answering the question:

Is the behaviour same for desktop and android (or was this only renabled for android?). If it is restored to android how are users supposed to set the preference, when there is no preference UI on current Android Firefox?

This is disabled everywhere including Android, and users are not expected to enable it again. It's present only for KaiOS for now.

Comment 16

[Hamish Willee]

Thanks very much. I think all the work for this is done now - updated in BCD and in docs. Tracking for that in https://github.com/mdn/content/issues/4308

Comment 17

[Chris Mills [:cmills]]

Docs completed, so setting this to DDC. Thanks Hamish!