Closed Bug 1699736 Opened 4 years ago Closed 4 years ago

Perma [tier 2] js\src\jit-test\tests\gc\bug-1698543.js | z:\task_1616148527\src\js\src\jit-test\tests\gc\bug-1698543.js:30:9 Error: regexp too big (code 3, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no

Categories

(Core :: JavaScript Engine, defect, P5)

defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- fixed
firefox89 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jonco)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=333756759&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cAAsNgPqT6izjTuAGW8Wyg/runs/0/artifacts/public/logs/live_backing.log


task 2021-03-19T11:16:03.431Z] FAIL - gc\bug-1698543.js
[task 2021-03-19T11:16:03.431Z] TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\gc\bug-1698543.js | z:\task_1616148527\src\js\src\jit-test\tests\gc\bug-1698543.js:30:9 Error: regexp too big (code 3, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.6 s]```

This is currently permafailing.

Jon, could you please take a look?

Flags: needinfo?(jcoppeard)
Regressed by: 1699364
Summary: Intermittent js\src\jit-test\tests\gc\bug-1698543.js | z:\task_1616148527\src\js\src\jit-test\tests\gc\bug-1698543.js:30:9 Error: regexp too big (code 3, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 → Perma [tier 2] js\src\jit-test\tests\gc\bug-1698543.js | z:\task_1616148527\src\js\src\jit-test\tests\gc\bug-1698543.js:30:9 Error: regexp too big (code 3, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no
Has Regression Range: --- → yes
Keywords: regression
No longer regressions: 1699364
Assignee: nobody → jcoppeard
Flags: needinfo?(jcoppeard)

The problem here is that the test relies on triggering overrecursion but this can also trigger regexp complication to fail with the error 'regexp too big'. It's ambiguous as to whether this indicates overrecursion or a regexp that's too large, so I don't think we can check for this in the test runner.

I checked that the testcase still triggers the original problem.

Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/438ac889a639 Update testcase for bug 1698543 to ignore stack space exhaustion in regexp compilation r=sfink
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

The patch landed in nightly and beta is affected.
:jonco, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(jcoppeard)
Flags: needinfo?(jcoppeard)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: