Closed Bug 1699790 Opened 3 years ago Closed 3 years ago

Last 10 cycles of https://www.vsynctester.com/gputest.html are very slow with remote canvas.

Categories

(Core :: Graphics: Canvas2D, defect, P1)

All
Windows
defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox86 --- wontfix
firefox87 --- wontfix
firefox88 --- wontfix
firefox89 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

Attachments

(1 file)

This is because of this setting in webrender, which gets propagated to this check in TextureClient and fails because the canvas gets bigger than 8192.
So, it falls back to a software canvas, which I think then gets drawn into a recording one and is really slow.

The textures can actually be 16384 (I think) and the moz2D limit mentioned in the webrender setting is actually a max allocation of 500MB, which means we could allow (square) textures of up to 11180, assuming 4Bpp.

Summary: Last 10 cycles of https://www.vsynctester.com/gputest.html a very slow with remote canvas. → Last 10 cycles of https://www.vsynctester.com/gputest.html are very slow with remote canvas.
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8350638712cf
Increase webrender max texture size to max allowed by Moz2D. r=nical
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

The patch landed in nightly and beta is affected.
:bobowen, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(bobowencode)
Regressions: 1701395

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #4)

The patch landed in nightly and beta is affected.
:bobowen, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Unfortunately, this has introduced a performance regression elsewhere, so I won't be uplifting yet.

Flags: needinfo?(bobowencode)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: