1699794 - Extend the GV Autocomplete API to support addresses

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[Eugen Sawin [:esawin]]

Split out from bug 1691819 because it's not blocking the MVP/initial release and address support needs more platform work.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: Bug 1699794 - [2.0] Add address autocomplete tests

Comment 2

[Eugen Sawin [:esawin]]

Attachment: Bug 1699794 - [3.0] Update API changelog

Depends on D109137

Comment 3

[Eugen Sawin [:esawin]]

Attachment: Bug 1699794 - [1.0] Extend GV Autocomplete API with address support

Comment 4

[Emily Toop (:fluffyemily)]

What does this need in order to land?

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Irene offered to help :)

Comment 6

[[:owlish] 🦉 PST]

So I checked as thoroughly as I could, and I don't see any bugs blocking this. In order to land, this needs:

• Another tests in https://phabricator.services.mozilla.com/D109137 as per Agi's request there
• Another review for this https://phabricator.services.mozilla.com/D109139

Comment 7

[[:owlish] 🦉 PST]

...as well as a rebase for all three patches and some amendments in https://phabricator.services.mozilla.com/D109138 (the API change won't be in 89 release)

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

Discussed during the autofill meeting, this work is not part of the CC autofill MVP.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfa7384a8874
[1.0] Extend GV Autocomplete API with address support r=geckoview-reviewers,agi,aklotz

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cede79b33b2
[2.0] Add address autocomplete tests r=geckoview-reviewers,agi

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b657128a173
[3.0] Update API changelog r=geckoview-reviewers,agi

Comment 12

[Sandor Molnar]

Backed out for causing mochitest failures in browser_autocomplete_footer

Backout link: https://hg.mozilla.org/integration/autoland/rev/4f7b60d2d51e72e14b3bfb1c357b254a876d1640

Push with failures

Failure log

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a5a0d8ea411
[2.0] Add address autocomplete tests r=geckoview-reviewers,agi

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c450490ac067
Backed out changeset 3a5a0d8ea411 for Browser-chrome failures in browser/extensions/formautofill/test/browser/browser_autocomplete_footer.js. CLOSED TREE

Comment 15

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/bfa7384a8874
https://hg.mozilla.org/mozilla-central/rev/9b657128a173

Comment 16

[[:owlish] 🦉 PST]

One of the changesets wasn't merged yet, reopening

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c99bb7d3308e
[2.0] Add address autocomplete tests r=geckoview-reviewers,agi

Comment 18

[Atila Butkovits]

Backed out for causing Mochitest failures in browser_anti_clickjacking.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/20ab2670b9f66f26a95664f44dcbe1d01a6c3a77

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=cEcXXGYLRPK-ip_wxsaLgw.0&revision=c99bb7d3308e2a60bd331f1292db0a5adaf36693&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan%2Fopt-mochitest-browser-chrome-e10s%2Cbc5

Failure log: https://treeherder.mozilla.org/logviewer?job_id=342554419&repo=autoland&lineNumber=2404

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcc24ac34f5d
[2.0] Add address autocomplete tests r=geckoview-reviewers,agi

Comment 20

[Sandor Molnar]

Backed out for causing mochitest failures in creditCard/test_clear_form

Backout link: https://hg.mozilla.org/integration/autoland/rev/db9b583794245e1df4f6e68e23f08d98fed0a118

Push with failures

Failure log

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0e739039d77
[2.0] Add address autocomplete tests r=geckoview-reviewers,agi

Comment 22

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d0e739039d77