Closed Bug 1699808 Opened 4 years ago Closed 4 years ago

Perma [tier 2] 0:27.61 python/mozbuild/mozbuild/test/test_rewrite_mozbuild.py::TestUtils::test_normalize_filename TEST-UNEXPECTED-FAIL

Tracking

(firefox-esr78 unaffected, firefox86 unaffected, firefox87 unaffected, firefox88 fixed, firefox89 fixed)

Status:

RESOLVED FIXED

Milestone:

89 Branch

Tracking Flags:

Tracking

Status

firefox-esr78

---

unaffected

firefox86

---

unaffected

firefox87

---

unaffected

firefox88

---

fixed

firefox89

---

fixed

People

(Reporter: intermittent-bug-filer, Assigned: tjr)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1699808: Fix test exception to use quotes 4 years ago Tom Ritter [:tjr] 48 bytes, text/x-phabricator-request		Details \| Review

Treeherder Bug Filer

Reporter

Description

•

4 years ago

treeherder

Filed by: malexandru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=333809626&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/WeYsgH-SQpitFyI18N3tKA/runs/0/artifacts/public/logs/live_backing.log

[task 2021-03-19T19:37:54.199Z]  0:27.08 python/mozbuild/mozbuild/test/test_preprocessor.py::TestPreprocessor::test_var_line PASSED
[task 2021-03-19T19:37:54.199Z]  0:27.08 
[task 2021-03-19T19:37:54.199Z]  0:27.08 ========================== 56 passed in 0.23 seconds ==========================
[task 2021-03-19T19:37:54.725Z]  0:27.61 Z:\task_1616181318\build\src\python\mozbuild\mozbuild\test\test_rewrite_mozbuild.py
[task 2021-03-19T19:37:54.725Z]  0:27.61 ============================= test session starts =============================
[task 2021-03-19T19:37:54.726Z]  0:27.61 platform win32 -- Python 2.7.15, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- Z:\task_1616181318\build\src\obj-x86_64-pc-mingw32\_virtualenvs\python-test\Scripts\python.exe
[task 2021-03-19T19:37:54.726Z]  0:27.61 rootdir: Z:\task_1616181318\build\src, inifile: Z:\task_1616181318\build\src\config\mozunit\mozunit\pytest.ini
[task 2021-03-19T19:37:54.727Z]  0:27.61 collecting ... collected 7 items
[task 2021-03-19T19:37:54.727Z]  0:27.61 
[task 2021-03-19T19:37:54.727Z]  0:27.61 python/mozbuild/mozbuild/test/test_rewrite_mozbuild.py::TestUtils::test_filenames_directory_is_in_filename_list PASSED
[task 2021-03-19T19:37:54.727Z]  0:27.61 python/mozbuild/mozbuild/test/test_rewrite_mozbuild.py::TestUtils::test_find_all_posible_assignments_from_filename PASSED
[task 2021-03-19T19:37:54.727Z]  0:27.61 python/mozbuild/mozbuild/test/test_rewrite_mozbuild.py::TestUtils::test_guess_best_assignment PASSED
[task 2021-03-19T19:37:54.728Z]  0:27.61 python/mozbuild/mozbuild/test/test_rewrite_mozbuild.py::TestUtils::test_mozbuild_adding PASSED
[task 2021-03-19T19:37:54.728Z]  0:27.61 python/mozbuild/mozbuild/test/test_rewrite_mozbuild.py::TestUtils::test_mozbuild_removing PASSED
[task 2021-03-19T19:37:54.728Z]  0:27.61 python/mozbuild/mozbuild/test/test_rewrite_mozbuild.py::TestUtils::test_normalize_filename TEST-UNEXPECTED-FAIL
[task 2021-03-19T19:37:54.728Z]  0:27.61 python/mozbuild/mozbuild/test/test_rewrite_mozbuild.py::TestUtils::test_unnormalize_filename TEST-UNEXPECTED-FAIL
[task 2021-03-19T19:37:54.728Z]  0:27.61 
[task 2021-03-19T19:37:54.728Z]  0:27.61 ================================== FAILURES ===================================
[task 2021-03-19T19:37:54.728Z]  0:27.61 ______________________ TestUtils.test_normalize_filename ______________________
[task 2021-03-19T19:37:54.728Z]  0:27.61 
[task 2021-03-19T19:37:54.728Z]  0:27.61 self = <mozbuild.test.test_rewrite_mozbuild.TestUtils testMethod=test_normalize_filename>
[task 2021-03-19T19:37:54.729Z]  0:27.61 
[task 2021-03-19T19:37:54.729Z]  0:27.61     def test_normalize_filename(self):
[task 2021-03-19T19:37:54.729Z]  0:27.61         self.assertEqual(mu.normalize_filename("foo/bar/moz.build", "/"), "/")
[task 2021-03-19T19:37:54.729Z]  0:27.61         self.assertEqual(
[task 2021-03-19T19:37:54.729Z]  0:27.61 >           mu.normalize_filename("foo/bar/moz.build", "a.c"), "foo/bar/a.c"
[task 2021-03-19T19:37:54.729Z]  0:27.61         )
[task 2021-03-19T19:37:54.729Z]  0:27.61 E       AssertionError: u'foo/bar\\a.c' != u'foo/bar/a.c'
[task 2021-03-19T19:37:54.729Z]  0:27.61 E       - foo/bar\a.c
[task 2021-03-19T19:37:54.730Z]  0:27.61 E       ?        ^
[task 2021-03-19T19:37:54.730Z]  0:27.61 E       + foo/bar/a.c
[task 2021-03-19T19:37:54.730Z]  0:27.61 E       ?        ^
[task 2021-03-19T19:37:54.730Z]  0:27.61 
[task 2021-03-19T19:37:54.730Z]  0:27.61 python\mozbuild\mozbuild\test\test_rewrite_mozbuild.py:50: AssertionError
[task 2021-03-19T19:37:54.730Z]  0:27.61 _____________________ TestUtils.test_unnormalize_filename _____________________
[task 2021-03-19T19:37:54.730Z]  0:27.61 
[task 2021-03-19T19:37:54.730Z]  0:27.61 self = <mozbuild.test.test_rewrite_mozbuild.TestUtils testMethod=test_unnormalize_filename>
[task 2021-03-19T19:37:54.730Z]  0:27.61 
[task 2021-03-19T19:37:54.731Z]  0:27.61     def test_unnormalize_filename(self):
[task 2021-03-19T19:37:54.731Z]  0:27.62         test_vectors = [
[task 2021-03-19T19:37:54.731Z]  0:27.62             (
[task 2021-03-19T19:37:54.731Z]  0:27.62                 "foo/bar/moz.build",
[task 2021-03-19T19:37:54.731Z]  0:27.62                 "/",
[task 2021-03-19T19:37:54.731Z]  0:27.62             ),
[task 2021-03-19T19:37:54.731Z]  0:27.62             ("foo/bar/moz.build", "a.c"),
[task 2021-03-19T19:37:54.731Z]  0:27.62             ("foo/bar/moz.build", "baz/a.c"),
[task 2021-03-19T19:37:54.731Z]  0:27.62             ("foo/bar/moz.build", "/a.c"),
[task 2021-03-19T19:37:54.731Z]  0:27.62         ]
[task 2021-03-19T19:37:54.731Z]  0:27.62 
[task 2021-03-19T19:37:54.731Z]  0:27.62         for vector in test_vectors:
[task 2021-03-19T19:37:54.731Z]  0:27.62             mozbuild, file = vector
[task 2021-03-19T19:37:54.731Z]  0:27.62             self.assertEqual(
[task 2021-03-19T19:37:54.731Z]  0:27.62                 mu.unnormalize_filename(
[task 2021-03-19T19:37:54.732Z]  0:27.62                     mozbuild, mu.normalize_filename(mozbuild, file)
[task 2021-03-19T19:37:54.732Z]  0:27.62                 ),
[task 2021-03-19T19:37:54.732Z]  0:27.62 >               file,
[task 2021-03-19T19:37:54.732Z]  0:27.62             )
[task 2021-03-19T19:37:54.732Z]  0:27.62 E           AssertionError: u'foo/bar\\a.c' != u'a.c'
[task 2021-03-19T19:37:54.732Z]  0:27.62 E           - foo/bar\a.c
[task 2021-03-19T19:37:54.733Z]  0:27.62 E           + a.c
[task 2021-03-19T19:37:54.733Z]  0:27.62 
[task 2021-03-19T19:37:54.733Z]  0:27.62 python\mozbuild\mozbuild\test\test_rewrite_mozbuild.py:74: AssertionError
[task 2021-03-19T19:37:54.733Z]  0:27.62 ===================== 2 failed, 5 passed in 0.08 seconds ======================
[task 2021-03-19T19:37:54.733Z]  0:27.62 Setting retcode to 1 from Z:\task_1616181318\build\src\python\mozbuild\mozbuild\test\test_rewrite_mozbuild.py
[task 2021-03-19T19:37:55.194Z]  0:28.08 Z:\task_1616181318\build\src\python\mozbuild\mozbuild\test\test_telemetry.py
[task 2021-03-19T19:37:55.195Z]  0:28.08 ============================= test session starts =============================
[task 2021-03-19T19:37:55.195Z]  0:28.08 platform win32 -- Python 2.7.15, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- Z:\task_1616181318\build\src\obj-x86_64-pc-mingw32\_virtualenvs\python-test\Scripts\python.exe
[task 2021-03-19T19:37:55.196Z]  0:28.08 rootdir: Z:\task_1616181318\build\src, inifile: Z:\task_1616181318\build\src\config\mozunit\mozunit\pytest.ini
[task 2021-03-19T19:37:55.196Z]  0:28.08 collecting ... collected 3 items
[task 2021-03-19T19:37:55.197Z]  0:28.08 
[task 2021-03-19T19:37:55.197Z]  0:28.08 python/mozbuild/mozbuild/test/test_telemetry.py::test_path_filtering PASSED
[task 2021-03-19T19:37:55.197Z]  0:28.08 python/mozbuild/mozbuild/test/test_telemetry.py::test_path_filtering_in_objdir PASSED
[task 2021-03-19T19:37:55.197Z]  0:28.08 python/mozbuild/mozbuild/test/test_telemetry.py::test_path_filtering_other_cwd PASSED
[task 2021-03-19T19:37:55.197Z]  0:28.08 
[task 2021-03-19T19:37:55.197Z]  0:28.08 ========================== 3 passed in 0.04 seconds ===========================
[task 2021-03-19T19:37:55.366Z]  0:28.25 Z:\task_1616181318\build\src\python\mozbuild\mozbuild\test\test_util.py
[task 2021-03-19T19:37:55.366Z]  0:28.25 ============================= test session starts =============================
[task 2021-03-19T19:37:55.367Z]  0:28.25 platform win32 -- Python 2.7.15, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- Z:\task_1616181318\build\src\obj-x86_64-pc-mingw32\_virtualenvs\python-test\Scripts\python.exe
[task 2021-03-19T19:37:55.368Z]  0:28.25 rootdir: Z:\task_1616181318\build\src, inifile: Z:\task_1616181318\build\src\config\mozunit\mozunit\pytest.ini
[task 2021-03-19T19:37:55.369Z]  0:28.25 collecting ... collected 53 items
[task 2021-03-19T19:37:55.369Z]  0:28.25 
[task 2021-03-19T19:37:55.370Z]  0:28.25 python/mozbuild/mozbuild/test/test_util.py::TestHashing::test_hash_file_known_hash PASSED```

Comment hidden (Intermittent Failures Robot)

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

4 years ago

status-firefox86: --- → unaffected

status-firefox87: --- → unaffected

status-firefox88: --- → affected

status-firefox89: --- → affected

status-firefox-esr78: --- → unaffected

Flags: needinfo?(tom)

Tom Ritter [:tjr]

Assignee

Comment 2

•

4 years ago

Attached file Bug 1699808: Fix test exception to use quotes — Details

Phabricator Automation

Updated

•

4 years ago

Assignee: nobody → tom

Status: NEW → ASSIGNED

Pulsebot

Comment 3

•

4 years ago

Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e6aef8bc591 Fix test exception to use quotes r=jewilde

Bogdan Tara[:bogdan_tara | bogdant]

Comment 4

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/4e6aef8bc591

Status: ASSIGNED → RESOLVED

Closed: 4 years ago

status-firefox89: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → 89 Branch

Ryan VanderMeulen [:RyanVM]

Comment 5

•

4 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/e1c30cbcd9be

status-firefox88: affected → fixed

Tom Ritter [:tjr]

Assignee

Updated

•

4 years ago

Flags: needinfo?(tom)

Comment hidden (Intermittent Failures Robot)

BMO Automation

Updated

•

4 years ago

Has Regression Range: --- → yes

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Perma [tier 2] 0:27.61 python/mozbuild/mozbuild/test/test_rewrite_mozbuild.py::TestUtils::test_normalize_filename TEST-UNEXPECTED-FAIL

Categories

(Firefox Build System :: General, defect, P5)

Tracking

(firefox-esr78 unaffected, firefox86 unaffected, firefox87 unaffected, firefox88 fixed, firefox89 fixed)

People

(Reporter: intermittent-bug-filer, Assigned: tjr)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Updated

Comment 2

Updated

Comment 3

Comment 4

Comment 5

Updated

Comment 6

Updated

Attachment

General

Description

File Name

Content Type