1699813 - Dark color when hovering the "Change search settings" button in searchbar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Pablo]

Attachment: darkbug.jpg

Darker highlight color in search toolbar button

Tested on Windows10 64bit , Ubuntu 20 and macos 10.15 using:
Firefox Release 86.0.1 not reproducible
Firefox beta 87.0 not reproducible
Firefox Nightly 88.0a1 reproducible

This is without proton, On nightly and Beta i see proton disabled by default

Steps

• go to about:preferences#search
• enable Add search bar in toolbar
• type anything in searchbar
• highlight change search settings button

actual results
The button now has a darker color than whats on release

expected results
Not sure if it should look lighter grey, specially when you hover the mouse over it so the letters are more visible.

Notes: I experienced something similar with the urlbar and search sugestions. and when doing a mozregression for urlbar it came with this , but address bar did not look that bad:

build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ByVx9YbCR8m_VRa-PtPwDQ/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: 7e9c682cee5e3beb8ca3b25de4ca26d11c6fee71
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4d4bc56f77a199234c625dfdd85d06c62caae273&tochange=7e9c682cee5e3beb8ca3b25de4ca26d11c6fee71
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: ByVx9YbCR8m_VRa-PtPwDQ

Bug 1696469 - Part 2 - Use Proton color system colors for color/background-color in the address bar and arrowpanels.

Comment 1

[Marco Bonardo [:mak]]

I'm doing some search bar fixes in bug 1695276, I can check this.

Comment 2

[Pablo]

This is without proton, On nightly and Beta i see proton disabled by default

Comment 3

[Marco Bonardo [:mak]]

Based on the regressing bug, I think the outcome is actually expected, because this button historically had a darker background and thus the hover effect is even darker. the overlay colors definitions changed across the whole theme in Bug 1696469 for both proton and photon.
BUT, in my opinion, there's no reason for the Change Search Settings button to be darker, that is mostly an heredity of australis that I cannot see in any other panel of the primary ui.
In bug 1695276 I'm indeed going this direction, and I think it makes sense to just remove the background and use the normal dimming in photon.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1699813 - Remove darker color from Change Search Settings button in searchbar. r=harry

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b32340c5a8b5
Remove darker color from Change Search Settings button in searchbar. r=harry,desktop-theme-reviewers

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b32340c5a8b5

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 9211462 [details]
Bug 1699813 - Remove darker color from Change Search Settings button in searchbar. r=harry

Beta/Release Uplift Approval Request

• User impact if declined: visual regression in the search bar, poor contrast on the button
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Check the search bar "Change Search Settings" button, we removed the darker background, so now has same background color as the panel and a same dimmed/selected effects as the other entries in the panel.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): styling changes
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9211462 [details]
Bug 1699813 - Remove darker color from Change Search Settings button in searchbar. r=harry

Approved for 88.0b4.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce71de2bac48

Comment 10

[Pablo]

This issue is verified as fixed on Ubuntu 20 , Windows 10 , and MacOS 10.14
with Firefox Beta 88.0b4 and Firefox Nightly 89.0a1 3/29/2021

User Agent Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0
build id.20210329095128